Update Segger SysView files to v3.10 #437
Conversation
boards.local.txt and platform.local.txt should never exist in main branch.
Note: This does not compile, which is expected. Need to apply patch file for RTOS v10 and restore existing configuration modifications.
When linking, get errors about undefined references to `SEGGER_RTT_ASM_WriteSkipNoLock`
Of course, had to apply them manually, as the patch file did not apply directly. This is because some files were renamed / moved relative to the original distribution, while others were deleted because they did not apply.
size_t is unsigned; the #defined constant was treated as an integer,
which caused the following warning:
In file included from cores\nRF5\Uart.cpp:21:0:
cores\nRF5\Arduino.h: In instantiation of
```C++
decltype ( ((b < a) ? b : a) )
min(const T&, const L&)
[with
T = unsigned int;
L = int;
decltype (((b < a) ? b : a)) = unsigned int
]:
```
cores\nRF5\Uart.cpp:228:54: required from here
cores\nRF5\Arduino.h:92:15: warning:
comparison between signed and unsigned integer expressions [-Wsign-compare]
return (b < a) ? b : a;
henrygab
changed the title
|
@henrygab thank you very much for your effort, I am currently on a tight schedule for other works. I will review this as soon as I could. Please be patient a little more :) |
|
Keeping this thread alive. |
|
That is coincident, I am reveiwing this just now 😃😃 |
There was a problem hiding this comment.
Superb!! Thank you very much for the PR. And sorry for the late response. We are releasing CLUE & Sense boards which are packed with sensor and TFT and lots of more stuffs, those get high priority to support.
Now, I somewhat remembered, I was a bit nervous with modifying FreeRTOS kernel at first. I guess we will miss-out several kernel events, but considered that is not worth the risk. Lots of thing could go wrong since that is initial work for the BSP.
I still hate modifying the kernel, but I am more confident now, since there is more set of eyes (yours) watching on this. If anything goes wrong, I will just nuke the modification with latest freeRTOS 10.3 😈
That is me, I could do better by excluding the files from compiling but the Arduino IDE doesn't allow to such things 😜 |
Yes, indeed! Not to mention the nrf52840-based metro express that's coming soon and already having a CircuitPython 5.0 release. Truly a busy time!
Yes, the Arduino environment does present some challenges. Thank you for accepting the PR. |
@hathach -- This is a precursor to any further work on #431. It focuses on updating the Segger SystemView / RTT files, without changing their use. Two minor bug fixes also included.
Adds
/boards.local.txtand/platform.local.txtto .gitignore, to prevent accidental pushes of those files.Copies SystemView 3.10 files over the existing versions, including adding two new files
SEGGER_RTT_printf.candSEGGER_RTT_ASM_ARMv7M.S.Note: Compilation at this commit fails with a linker error,
undefined reference to SEGGER_RTT_ASM_WriteSkipNoLock.Restore existing pre-PR modifications to SEGGER files, to disable use of the ASM version of the function, thus avoiding the linker error.
Applies the FreeRTOSv10_Core.patch file, modified as needed for this depot.
Restore existing pre-PR modifications to SEGGER files, so SysView functions have no implementation when debug level is less than < 3.
Fix compilation warning because it should always be clean building with warnings enabled.
😉 Please accept my most sincere apologies for being unable to update the SEGGER files by simply copying them. It appears that someone made modifications to the previously used SEGGER files, thus preventing me from honoring your request to avoid (absolutely and under no circumstances) making any changes to those files, while still having the system build properly. 😉