Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _irq_handler #791

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix _irq_handler #791

merged 1 commit into from
Oct 16, 2023

Conversation

rmccaskill
Copy link
Contributor

I'm working on a project that has 3 rotary encoders. When I used this libary, I couldn't get the 3 switches to properly increment / decrement the steps when I called readAbs(). Looking back at the code, I see there was a change in 351cd82 which seemed to have caused the issue.

If I look previous to 351cd82, the _irq_handler was using digitalRead. I think switching to bitRead caused a mix up between the physical pin number vs. the port pin? I'm not entirely sure. I reimplemented the pre 351cd82 code and used the new ada_callback. Seems to be working great now!

I'm working on a project that has 3 rotary encoders. When I used this libary, I couldn't get the 3 switches to properly increment / decrement the steps when I called readAbs().
Looking back at the code, I see there was a change in 351cd82 which seemed to have caused the issue.

If I look previous to 351cd82, the _irq_handler was using digitalRead. I think switching to bitRead caused a mix up between the physical pin number vs. the port pin? I'm not entirely sure.
I reimplemented the pre 351cd82 code and used the new ada_callback. Seems to be working great now!
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look great, thank you for the fix. Strangely ci failed, but it isn't caused by this PR, probably due to other libraries update. Aprroved, but give me a bit of time to check out what is wrong, before merging.

@hathach hathach merged commit af19cea into adafruit:master Oct 16, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants