Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nrf52833 cores to the BSP #814

Closed
wants to merge 4 commits into from

Conversation

jeffc
Copy link

@jeffc jeffc commented Mar 15, 2024

This adds support for the nrf52833 to the BSP, including the linker settings, softdevice 7.2.0 and 7.3.0 headers (to match what's available in the bootloader), and updates to the included libraries where appropriate.

This does not add any board definitions, but does include scaffolding in the makeboards.py to allow for new nrf52833 boards to be added based on these changes.

This is loosely based on #659

@ndoo
Copy link

ndoo commented May 24, 2024

@ladyada @hathach sorry to bump this PR but I'm hoping this can be reviewed and pushed as it's relatively straightforward of a review (no regressions by the looks of it - mostly new files).

This would add native support for Seeed XIAO BLE which is an s140 7.3.0 device in Arduino IDE and downstream projects like PlatformIO.

Personally, I noticed this issue because Meshtastic firmware builds using PlatformIO which uses this repo as its upstream for nRF52 support, and right now we have to produce builds by hand by manually adding the files from 691e478 of this PR - https://github.com/meshtastic/firmware/tree/master/variants/xiao_ble

@ladyada ladyada requested a review from hathach May 24, 2024 16:05
@ladyada
Copy link
Member

ladyada commented May 24, 2024

sure, @hathach can take a look when they have time next

@ndoo
Copy link

ndoo commented Jun 1, 2024

Hi @hathach, could I please request you to take a look at adding the updated softdevice versions?

@hathach
Copy link
Member

hathach commented Jun 5, 2024

nrf52833 is just supported by #739, tested with pca10100, we have it on draft but didn't have time to finish it previously. To make it easier to maintain, we will only support SD v7.3, there is probably not much of difference between v7.2.0 and v7.3.0. Thank you for the PR. #739 misses anything, feel free to submit an PR

@hathach hathach closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants