Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for the Challenger 840 BLE board #267

Merged
merged 6 commits into from
Jun 27, 2022

Conversation

PontusO
Copy link
Contributor

@PontusO PontusO commented Jun 23, 2022

This PR adds support for the Challenger 840 BLE board.
It also adds the possibility to add a board specific initialization function (extern_board_init()) to the board specific files. This is done by having a weak declared function in boards.c that can be overridden by the board specific files.

@hathach
Copy link
Member

hathach commented Jun 24, 2022

look great, you should also add the board to githubci.yml as well for it to be included in the release binaries

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more last-minute request change, I still prefer to have board_ as prefix for the weak function. Could you rename it from extern_board_init() to board_init_extra()

src/boards/boards.c Outdated Show resolved Hide resolved
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me, thank you for the pr

@hathach hathach merged commit e75aa4f into adafruit:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants