Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XIAO BLE Sense boards #291

Merged
merged 5 commits into from
Feb 8, 2023

Conversation

aovestdipaperino
Copy link
Contributor

Added support for Xiao BLE nrf52840 boards.
IDs are taken from here: https://github.com/0hotpotman0/Adafruit_nRF52_Bootloader

Changes:

  • number of LEDs is set to 1, because a larger number causes OTA issues ¯_(ツ)_/¯
  • Set the proper SD version in the .mk files, again to fix OTA issues due to mismatched version.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please correct the BOARD_ID and also add these new boards to the ci as well https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/.github/workflows/githubci.yml#L17

src/boards/xiao_nrf52840_ble/board.h Outdated Show resolved Hide resolved
src/boards/xiao_nrf52840_ble_sense/board.h Outdated Show resolved Hide resolved
UF2 board ID updated to specs.
Added:
-xiao_nrf52840_ble
-xiao_nrf52840_ble_sense
@aovestdipaperino
Copy link
Contributor Author

Fixed all suggestions.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, thank you for your PR

@hathach hathach merged commit 2107d4e into adafruit:master Feb 8, 2023
@faizannazir
Copy link

only led blinking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants