Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new variant #286

Merged
merged 2 commits into from
Mar 15, 2021
Merged

add new variant #286

merged 2 commits into from
Mar 15, 2021

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Mar 14, 2021

No description provided.

@ladyada ladyada requested a review from hathach March 14, 2021 21:23
hathach
hathach reviewed Mar 15, 2021
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for the minor typo for the openocd_scripts, everything else look great.

boards.txt Outdated Show resolved Hide resolved
variants/neotrinkey_m0/variant.h Show resolved Hide resolved
@ladyada ladyada requested a review from hathach March 15, 2021 16:14
hathach
hathach approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look perfect now 👍

@hathach hathach merged commit 9e15226 into master Mar 15, 2021
@hathach hathach deleted the neotrinkey branch March 15, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladyada @hathach