Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to move zip-directory to "." (top level) of output zip file? #18

Open
jake1164 opened this issue Sep 6, 2023 · 9 comments
Open

Option to move zip-directory to "." (top level) of output zip file? #18

jake1164 opened this issue Sep 6, 2023 · 9 comments

Comments

@jake1164
Copy link
Contributor

jake1164 commented Sep 6, 2023

All of my code is in a src/ folder so I have the zip-directory set to "src". The output of the mpy-zip is a src folder with the mpy files inside it, however, ideally I would love the src to be moved to the top folder ".".
@tekktrik
Copy link
Member

Hi, sorry for the incredibly delayed response. So you're saying you want to run mpy-cross on the src/ folder but in the zip folder put that in the top level? Is that an example (or exactly) the use case you're describing?

@jake1164
Copy link
Contributor Author

Hi, Yes that is the exact use case but probably should be slightly more generic incase people have the source in another sub folder.

@tekktrik
Copy link
Member

If you want to compile the src/ folder but zip the top level, you should be able to set the zip directory to . (which is the default) and set the mpy directory to src/.  Please let me know if that helps or if I'm still misunderstanding!

@jake1164
Copy link
Contributor Author

jake1164 commented Dec 29, 2023 via email

@tekktrik
Copy link
Member

tekktrik commented Jan 9, 2024

Hi, did that solve your issue?

@jake1164
Copy link
Contributor Author

jake1164 commented Jan 9, 2024 via email

@jake1164
Copy link
Contributor Author

jake1164 commented Jan 16, 2024 via email

@tekktrik
Copy link
Member

I'm still a little unclear of what the desired state you're looking for is. Would you mind creating a text or image diagram of the current and desired output of the tool?

I can however say that depending on what that is, it may be slightly out of scope. The goal of the action is to compile CircuitPython files and either zip them or a larger subset that includes them (i.e., zipping the compiled files or the entire project). if you want you're asking for is for the output to reflect a different filetree (or sub-filetree) than than repository, you may want to move things in the CI prior to running the actions using commands like mv.

But I may be misunderstanding your request, so please let me know if that isn't applicable to your request.

@jake1164
Copy link
Contributor Author

jake1164 commented Mar 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jake1164 @tekktrik