Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial RP2040 support #4031

Merged
merged 12 commits into from
Jan 21, 2021
Merged

Add initial RP2040 support #4031

merged 12 commits into from
Jan 21, 2021

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jan 21, 2021 •
edited
Loading

The RP2040 is new microcontroller from Raspberry Pi that features
two Cortex M0s and eight PIO state machines that are good for
crunching lots of data. It has 264k RAM and a built in UF2
bootloader too.

Datasheet: https://datasheets.raspberrypi.org/rp2040/rp2040_datasheet.pdf

@tannewt
Add initial RP2040 support
733094a 
The RP2040 is new microcontroller from Raspberry Pi that features
two Cortex M0s and eight PIO state machines that are good for
crunching lots of data. It has 264k RAM and a built in UF2
bootloader too.

Datasheet: https://pico.raspberrypi.org/files/rp2040_datasheet.pdf
@tannewt
Fix warnings that come from -O3 (I think)
2b4ad1e
@tannewt
Temporarily turn off string op overflow check
4872158
@tannewt
Fix press any key message
fb1e010
@tannewt tannewt requested a review from dhalbert January 21, 2021 07:20
@tannewt tannewt added rp2040 Raspberry Pi RP2040 enhancement labels Jan 21, 2021
tannewt and others added 3 commits January 20, 2021 23:30
@tannewt
pre-commit
6a6f22b
@tannewt
type fix
b0f7fd9
@dhalbert
Change xtensa cache key
dbd5b7d 
again, we need to stop using a bad cache for ESP32-S2 builds
dhalbert
dhalbert requested changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did an extremely quick pass. Fantastic!

  • I did update the esp32s2 build cache key, but the esp32s2 builds are failing due to a newly guarded include in supervisor/shared/safe_mode.c. I would try to fix it but I can't push to your PR's.
  • Trivial copyediting. Not important.
  • Calling the port raspberrypi might be confusing given one of your aspirations. 😃 Did you think about rp2 or similar?

ports/raspberrypi/bindings/rp2pio/StateMachine.c Outdated Show resolved Hide resolved
ports/raspberrypi/bindings/rp2pio/StateMachine.c Outdated Show resolved Hide resolved
py/circuitpy_mpconfig.h Outdated Show resolved Hide resolved
py/circuitpy_mpconfig.h Outdated Show resolved Hide resolved
supervisor/shared/safe_mode.c Outdated Show resolved Hide resolved
@tannewt
Copy link
Member Author

tannewt commented Jan 21, 2021 

* Calling the port `raspberrypi` might be confusing given one of your aspirations. smiley  Did you think about `rp2` or similar?

I know it might be confusing. MicroPython is rp2 so we can't use it. My thought is that this is the chip manufacturer. For raspberry pi boards we'll add ports/broadcom.

@dhalbert
Copy link
Collaborator

dhalbert commented Jan 21, 2021 •
edited
Loading 

* Calling the port `raspberrypi` might be confusing given one of your aspirations. smiley  Did you think about `rp2` or similar?

I know it might be confusing. MicroPython is rp2 so we can't use it. My thought is that this is the chip manufacturer. For raspberry pi boards we'll add ports/broadcom.

Fine by me! Could be rpi or rp2x but raspberrypi fine as well. I will just type [tab] 😄 .

@dhalbert
Copy link
Collaborator

sparkfun_samd21_dev for de_DE ran out of space. Will try to fix that.

@dhalbert dhalbert mentioned this pull request Jan 21, 2021
Merged
dhalbert
dhalbert approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changes!

@dhalbert dhalbert merged commit 2249a33 into adafruit:main Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
enhancement rp2040 Raspberry Pi RP2040
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @dhalbert