Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mp3 output on esp32s3 #9218

Merged
merged 15 commits into from
May 2, 2024
Merged

Enable mp3 output on esp32s3 #9218

merged 15 commits into from
May 2, 2024

Commits on May 1, 2024

  1. espressif: fix build error when WIFI && !SSL

    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b8f3d23 View commit details
    Browse the repository at this point in the history

  2. espressif: Fix queueing background tasks from other core

    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9164629 View commit details
    Browse the repository at this point in the history

  3. espressif: Don't hold interrupts disabled a long time 

    .. just to prevent background tasks from running
    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    08a440d View commit details
    Browse the repository at this point in the history

  4. espressif: enable MP3Decoder on esp32s3

    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    50a971e View commit details
    Browse the repository at this point in the history

  5. espressif: i2sout: Comment on these constants better

    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6237a14 View commit details
    Browse the repository at this point in the history

  6. espressif: Use Philips data format for i2s 

    it's the standard i2s format, and what's needed for max98357 breakout.
    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6136c33 View commit details
    Browse the repository at this point in the history

  7. MP3Decoder: ensure object uses finalizer 

    .. so that the underlying allocations will be freed. This is not
important now but will be if the underlying allocator is changed
to something else like `port_malloc` in the future.
    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a8170f9 View commit details
    Browse the repository at this point in the history

  8. MP3Decoder: Allow port to override the allocator 

    .. espressif will be able to put the mp3 data in faster RAM this way.
    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7af2a13 View commit details
    Browse the repository at this point in the history

  9. espressif: use custom allocator for MP3Decoder data

    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    aee66b2 View commit details
    Browse the repository at this point in the history

  10. MP3Decoder: update mp3 submodule 

    These changes have been requested upstream at adafruit/Adafruit_MP3#21
    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    334287b View commit details
    Browse the repository at this point in the history

  11. MP3Decoder: Request defined behavior for signed integer shifts 

    gcc -fsanitize=undefined reports diagnostics like these:
```
../../src/bitstream.c:93:36: runtime error: left shift of 177 by 24 places cannot be represented in type 'int'
../../src/imdct.c:86:53: runtime error: left shift of negative value -937
```

-fwrapv provides implementation-defined behavior that matches the expectations of two's complement arithmetic.
    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    34a46de View commit details
    Browse the repository at this point in the history

  12. MP3Decoder: Need to zero out storage

    @jepler
    jepler committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c7807cf View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. try enabling mp3 on any espressif chip with at least 4MB flash

    @jepler
    jepler committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d68efb8 View commit details
    Browse the repository at this point in the history

  2. disable on 4MB C6, for now

    @jepler
    jepler committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4f020a2 View commit details
    Browse the repository at this point in the history

  3. Update ports/espressif/mpconfigport.mk 

    Co-authored-by: Scott Shawcroft <scott@tannewt.org>
    @jepler @tannewt
    jepler and tannewt committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8cbd9d9 View commit details
    Browse the repository at this point in the history