New board version: Nano 33 BLE Rev2 #9347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Thanks for the typo fixes in the description.
I think it would be better for this to be a new board definition. It's a new product with a new stock number: https://store.arduino.cc/products/nano-33-ble-sense-rev2. A new entry (by PR)would be added to circuitpython.org as well. Assuming so, take the _V2 off the pin names.
dhalbert
requested changes
Jun 19, 2024
dhalbert
changed the title
|
Could you also prepare a PR to add this new board to circuitpython.org? See https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website. Thanks! |
dhalbert
requested changes
Jun 19, 2024
dhalbert
approved these changes
Jun 19, 2024
applecuckoo
changed the title
This was referenced Jun 20, 2024
|
I've opened a PR for the website - see adafruit/circuitpython-org#1426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick addition to define a couple of interrupt pins only available on the second revision of the Arduino Nano 33 BLE Sense. In a way, this is to close my own issue, #7991.
I figured that since there weren't any pin-related breaking changes between the two revisions, it was better to add to the existing definition.
This is only based on pin diagrams since I don't have the actual hardware to test this.