Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared/runtime/sys_stdio_mphal: Fix docstring for stdio. #9598

Merged
merged 6 commits into from
Sep 9, 2024
Merged

shared/runtime/sys_stdio_mphal: Fix docstring for stdio. #9598

merged 6 commits into from
Sep 9, 2024

Conversation

timdechant
Copy link

Incorporating stdio recommendations from micropython#15708.

@timdechant
shared/runtime/sys_stdio_mphal: Fix docstring for stdio.
c6c4c79 
Signed-off-by: timdechant <timdechant.git@gmail.com>
@timdechant
shared/runtime/sys_stdio_mphal: Fix docstring for stdio.
8b873b6 
Signed-off-by: timdechant <timdechant.git@gmail.com>
@timdechant
shared/runtime/sys_stdio_mphal: Fix docstring for stdio.
67c8b07 
Signed-off-by: timdechant <timdechant.git@gmail.com>
@timdechant
shared/runtime/sys_stdio_mphal: Fix docstring for stdio.
319fb89 
Signed-off-by: timdechant <timdechant.git@gmail.com>
@timdechant
shared/runtime/sys_stdio_mphal: Fix docstring for stdio.
da58110 
Signed-off-by: timdechant <timdechant.git@gmail.com>
dhalbert
dhalbert approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It was good to get Damien's take on this.

dhalbert
dhalbert requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Metro M0 build German build is overflowing by 16 bytes. Tomorrow I will see about shrinking this build slightly. The other build failures are transient CI issues.

dhalbert
dhalbert approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it fits!

@dhalbert dhalbert merged commit 561578f into adafruit:main Sep 9, 2024
17 checks passed
@timdechant
Copy link
Author

Thanks, Dan! And thanks for all your work here, it's a great project!

@timdechant timdechant deleted the micropython-merge branch September 9, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timdechant @dhalbert