-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pico_Plus_2: cleanup pin-names #9803
Conversation
I believe the SPICE name was copied from what @Gadgetoid set within our C header for the product (e.g. https://github.com/pimoroni/pimoroni-pico-rp2350/blob/feature/wireless/micropython/board/PIMORONI_PICO_PLUS2/pimoroni_pico_plus2w_rp2350.h), though why he included the The other changes sound sensible to me. |
Whatever is consistent for your pin names elsewhere (MicroPython, Arduino, board silk, etc.) is OK with us. The pin can have multiple names if that would be helpful. |
Although I use SPICE for simulation and when I am cooking, I have no problem reverting to SPICE naming again to make all spice boys and girls happy. Just let me know. |
@ZodiusInfuser @Gadgetoid Is Pimoroni in agreement that it should be |
I'm going to defer to @ZodiusInfuser on this one 👀 We can probably change the Pico SDK headers to |
Thanks for that ..... Go with |
As per discussion on adafruit/circuitpython#9803 Change "SPICE" to "SPCE" for consistency. Signed-off-by: Phil Howard <github@gadgetoid.com>
As per discussion on adafruit/circuitpython#9803 Change "SPICE" to "SPCE" for consistency. Signed-off-by: Phil Howard <github@gadgetoid.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have settled on the names. Thanks everyone.
This PR does some cleanup on pin-names:
SPICE_xxx
toSPCE_xxx
(Pimoroni calls their connector SP/CE)SPI
(board.SPI()
throwsNotImplementedError
anyways)GPxx
names since all pins are normal GPIOs as wellSPICE_TX
andSPICE_RX
. RX/TX pin names are UART-related on other boards. Here, they are only inclusive names for MOSI/MISO. It turns out thatSPICE_TX
is an UART-RX and vice versa. So to avoid confusion, I removed the names.Adding a
board_spi_obj
(thus preventing theNotImplementedError
) would be possible, but I don't think this makes sense. The SP/CE connector lacks a DC-pin and busy-pin. So to drive a SPI-screen, it is better to create an SPI object without MISO and use the pin for DC.I would even suggest to remove
SCK
,MISO
andMOSI
as well. They are already defined asSPCE_SCK
(and so on). The pure names suggest that there is something like a default SCK/MISO/MOSI on the Pico, which is not the case and is not implemented for other Pico-boards.@ZodiusInfuser: maybe you could chime in and share your opinion regarding the pin-names