Enable BOD33 protection for SAMD21 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was confusing on boards that don't have simple LED's on board. There was an 8-second delay for no apparent reason. I checked the update without a delay on Linux, macOS 13.1 (on an M1), and Windows 10, and the hosts did not have a problem remounting the BOOT drive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selfmain.c(update-bootloader). This was confusing on boards without an LED: users might reset the board before the BOOTPROT was set properly. Tested without delay on Windows, macOS, and Linux in case there was some remounting problem.Original support thread about this: https://forums.adafruit.com/viewtopic.php?t=198035