Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatted plots and reset carbon tax default to 0 #3

Open
wants to merge 1 commit into
base: multiperiod_aaa
Choose a base branch
from

Conversation

arao53
Copy link

@arao53 arao53 commented Aug 26, 2022

Fixes/Addresses:

Resolved LCOW value error and reformatting visualize_results.

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.


ax[2, 1].plot(time_step, pressure * 1e-5)
ax[2, 1].plot(time_step, 100 * pressure / (80e5))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arao53 With regard to the pressure, now that I think about it, the capital cost of the pump will vary by pressure and flow rate (essentially power consumption) unless we specify that the pump should be costed by the design pressure and flow rate of the pump. Not sure if that's the case

adam-a-a pushed a commit that referenced this pull request Aug 30, 2022
adam-a-a pushed a commit that referenced this pull request Aug 14, 2023
Update AD & AS models and tests
adam-a-a pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants