Fix target_versions for FileMode #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Jan 29, 2022
tests/blacken_docs_test.py
Outdated
| @@ -414,14 +414,14 @@ def test_integration_multiple_target_version(tmpdir): | |||
| 'def very_very_long_function_name(\n' | |||
| ' very_very_very_very_very_very,\n' | |||
| ' very_very_very_very_very_very,\n' | |||
| ' *long_long_long_long_long_long\n' | |||
| ' *long_long_long_long_long_long,\n' | |||
There was a problem hiding this comment.
this no longer demonstrates the behaviour that the option is honored -- the test would "pass" even if no options were being forwarded along
There was a problem hiding this comment.
That's true, I think I should pass an early-py3 target version instead.
There was a problem hiding this comment.
Fixed by using py35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141