Drop Python 3.8 support (#488)

Now EOL: https://discuss.python.org/t/python-3-8-is-now-officially-eol/66983 .
adamchainz · Oct 25, 2024 · 44b4e17 · 44b4e17
1 parent 9087769
commit 44b4e17
Show file tree

Hide file tree

Showing 12 changed files with 6 additions and 653 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -20,7 +20,6 @@ jobs:
     strategy:
       matrix:
         python-version:
-        - 3.8
         - 3.9
         - '3.10'
         - '3.11'

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -39,7 +39,7 @@ repos:
   rev: v3.17.0
   hooks:
   - id: pyupgrade
-    args: [--py38-plus]
+    args: [--py39-plus]
 - repo: https://github.com/adamchainz/django-upgrade
   rev: 1.21.0
   hooks:

diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -2,6 +2,8 @@
 Changelog
 =========
 
+* Drop Python 3.8 support.
+
 * Support Python 3.13.
 
 1.19.0 (2024-08-05)

diff --git a/docs/installation.rst b/docs/installation.rst
@@ -4,7 +4,7 @@ Installation
 Requirements
 ------------
 
-Python 3.8 to 3.13 supported.
+Python 3.9 to 3.13 supported.
 
 Django 3.2 to 5.1 supported.
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -15,7 +15,7 @@ keywords = [
 authors = [
   { name = "Adam Johnson", email = "me@adamj.eu" },
 ]
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 classifiers = [
   "Development Status :: 5 - Production/Stable",
   "Framework :: Django :: 3.2",
@@ -29,7 +29,6 @@ classifiers = [
   "Natural Language :: English",
   "Operating System :: OS Independent",
   "Programming Language :: Python :: 3 :: Only",
-  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",

diff --git a/src/django_htmx/middleware.py b/src/django_htmx/middleware.py
@@ -1,8 +1,8 @@
 from __future__ import annotations
 
 import json
+from collections.abc import Awaitable
 from typing import Any
-from typing import Awaitable
 from typing import Callable
 from urllib.parse import unquote
 from urllib.parse import urlsplit

diff --git a/tests/requirements/compile.py b/tests/requirements/compile.py
@@ -21,46 +21,6 @@
         *sys.argv[1:],
     ]
     run = partial(subprocess.run, check=True)
-    run(
-        [
-            *common_args,
-            "--python",
-            "3.8",
-            "--output-file",
-            "py38-django32.txt",
-        ],
-        input=b"Django>=3.2a1,<3.3",
-    )
-    run(
-        [
-            *common_args,
-            "--python",
-            "3.8",
-            "--output-file",
-            "py38-django40.txt",
-        ],
-        input=b"Django>=4.0a1,<4.1",
-    )
-    run(
-        [
-            *common_args,
-            "--python",
-            "3.8",
-            "--output-file",
-            "py38-django41.txt",
-        ],
-        input=b"Django>=4.1a1,<4.2",
-    )
-    run(
-        [
-            *common_args,
-            "--python",
-            "3.8",
-            "--output-file",
-            "py38-django42.txt",
-        ],
-        input=b"Django>=4.2a1,<5.0",
-    )
     run(
         [
             *common_args,

diff --git a/tests/requirements/py38-django32.txt b/tests/requirements/py38-django32.txt
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,7 +20,6 @@ jobs: @@
         strategy:
           matrix:
             python-version:
-            - 3.8
             - 3.9
             - '3.10'
             - '3.11'
@@ Expand Down @@