Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

iOS fix #86

Closed
wants to merge 4 commits into from
Closed

iOS fix #86

wants to merge 4 commits into from

Conversation

kirill-zhukov
Copy link

According to AppStore requirements we can't open browser as a separate app in iOS, our last app has been declined because of this. So I've added a possibility to be able to use SafariView under iOS for this. So the integration is seemless and works out of the box. Now the library is fully compatible with both platforms.

@kirill-zhukov
Copy link
Author

However I guess README.md should not be commited, sorry :)

@adamjmcgrath
Copy link
Owner

Hi, apologies for the delay getting back to you. I'm surprised that Linking.openURL would not work for any iOS react-native app - I can't see any mention of that in the docs (http://facebook.github.io/react-native/docs/linking.html#openurl).

I'm not really keen on introducing react-native-safari-view as a dependency. That said, you should be able to compose a login function that does what you want - so I'd be happy to accept a PR that allowed the user to pass in a urlOpener function as part of the options.

So the dance function would look something like:

export const dance = (authUrl, urlOpener = Linking.openURL) => {
   ...
  return urlOpener(authUrl)
    .then(...

@eqyiel
Copy link

eqyiel commented May 8, 2018

I think this is more of an issue now, see this thread: openid/AppAuth-iOS#120 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants