Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 2 vulnerabilities #1052

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

adamlaska
Copy link
Owner

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/order-utils/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-8187303
  828  
high severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-8172694
  701  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Copy link

google-cla bot commented Oct 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@0x/abi-gen@5.8.5 filesystem, shell Transitive: environment, network +30 8.9 MB tobernguyen
npm/@0x/base-contract@6.5.0 Transitive: environment, eval, network +45 12.9 MB dorothy-zbornak
npm/@0x/contract-wrappers@13.23.8 Transitive: environment, eval, network +48 20.2 MB tobernguyen
npm/@0x/contracts-erc1155@2.1.37 Transitive: environment, network +21 8.61 MB dorothy-zbornak
npm/@0x/contracts-erc20@3.3.57 Transitive: environment, eval, network +45 18.4 MB tobernguyen
npm/@0x/contracts-erc721@3.1.37 None 0 613 kB dorothy-zbornak
npm/@0x/contracts-exchange-libs@4.3.37 Transitive: environment, network +21 8.17 MB dorothy-zbornak
npm/@0x/contracts-gen@2.0.51 Transitive: environment, filesystem, network +22 7.81 MB tobernguyen
npm/@0x/contracts-test-utils@5.4.60 environment Transitive: eval, filesystem, network +71 75 MB tobernguyen
npm/@0x/contracts-utils@4.8.52 Transitive: environment, eval, network +45 17.5 MB tobernguyen
npm/@0x/dev-utils@3.3.6 environment, filesystem Transitive: eval, network, shell +92 27.7 MB dorothy-zbornak
npm/@0x/order-utils@10.4.28 Transitive: environment, eval, network +27 9.15 MB dorothy-zbornak
npm/@0x/sol-compiler@4.8.5 environment, filesystem, network, shell Transitive: eval +33 9.38 MB tobernguyen
npm/@0x/ts-doc-gen@0.0.22 filesystem Transitive: environment, network +35 10.4 MB fberger
npm/@0x/tslint-config@4.1.5 None +1 758 kB dekz
npm/@0x/types@3.3.7 None +2 1.15 MB dekz
npm/@0x/typescript-typings@5.3.2 None +5 2.85 MB dekz
npm/@0x/utils@5.6.4 network Transitive: environment +22 8.35 MB dorothy-zbornak
npm/@0x/web3-wrapper@7.6.5 Transitive: environment, eval, network +26 8.95 MB dorothy-zbornak
npm/chai-as-promised@7.1.2 None +1 42.6 kB chaijs
npm/chai@4.5.0 None +3 789 kB chaijs
npm/dirty-chai@2.0.1 None 0 20.3 kB joshperry
npm/ethereum-types@3.7.1 None +2 1.11 MB dekz

🚮 Removed packages: npm/make-promises-safe@1.1.0

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/babel-traverse@6.26.0 ⚠︎
Git dependency npm/eth-sig-util@1.4.2 ⚠︎
Protestware or potentially unwanted behavior npm/es5-ext@0.10.64
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
⚠︎
Protestware or potentially unwanted behavior npm/es5-ext@0.10.64
  • Note: The script attempts to run a local post-install script, which could potentially contain malicious code. The error handling suggests that it is designed to fail silently, which is a common tactic in malicious scripts.
⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What are git dependencies?

Contains a dependency which resolves to a remote git URL. Dependencies fetched from git URLs are not immutable can be used to inject untrusted code or reduce the likelihood of a reproducible install.

Publish the git dependency to npm or a private package repository and consume it from there.

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/babel-traverse@6.26.0
  • @SocketSecurity ignore npm/eth-sig-util@1.4.2
  • @SocketSecurity ignore npm/es5-ext@0.10.64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants