Skip to content

Commit

Permalink
Update index.d.ts (web3#5260)
Browse files Browse the repository at this point in the history
* Update CHANGELOG.md

* Update index.d.ts (web3#4955)

this callback returns an array of event data

Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com>
Co-authored-by: Nazar Hussain <nazarhussain@gmail.com>
Co-authored-by: Nikos Iliakis <nikoulai@users.noreply.github.com>

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>

* fix CHANGELOG

Co-authored-by: bigbizze <42508203+bigbizze@users.noreply.github.com>
Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com>
Co-authored-by: Nikos Iliakis <nikoulai@users.noreply.github.com>
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
  • Loading branch information
7 people authored Sep 20, 2022
1 parent c924148 commit a7b5dea
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -602,5 +602,9 @@ Released with 1.0.0-beta.37 code base.
- Support of `safe` and `finalized` block tags added (#5410)

## [Unreleased]
## [1.8.1]
### Fixed
- Fixed types for getPastEvents (#4955) (#5260)



## [1.8.1]
4 changes: 2 additions & 2 deletions packages/web3-eth-contract/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@ export class Contract {
getPastEvents(
event: string,
options: PastEventOptions,
callback: (error: Error, event: EventData) => void
callback: (error: Error, events: EventData[]) => void
): Promise<EventData[]>;
getPastEvents(event: string, options: PastEventOptions): Promise<EventData[]>;
getPastEvents(
event: string,
callback: (error: Error, event: EventData) => void
callback: (error: Error, events: EventData[]) => void
): Promise<EventData[]>;
}

Expand Down

0 comments on commit a7b5dea

Please sign in to comment.