Shortened platform flag check before verifying commit changes

adamlui · Dec 19, 2024 · 637376b · 637376b
1 parent a36b32f
commit 637376b
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/brave-omnibox/utils/bump.sh b/brave-omnibox/utils/bump.sh
@@ -38,7 +38,7 @@ for manifest_path in "${MANIFEST_PATHS[@]}" ; do
 
     # Check latest commit for extension changes if forcible platform flag not set
     platform_manifest_path=$(dirname "$manifest_path" | sed 's|^\./||')
-    if [ "$chromium_only" != true ] && [ "$ff_only" != true ] ; then
+    if [[ ! "${chromium_only} ${ff_only}" =~ "true" ]] ; then
         echo "Checking last commit details for $platform_manifest_path..."
         latest_platform_commit_msg=$(git log -1 --format=%s -- "$platform_manifest_path")
         echo -e "${DG}${latest_platform_commit_msg}${NC}\n"

diff --git a/chatgpt-auto-continue/utils/bump/extension-manifests.sh b/chatgpt-auto-continue/utils/bump/extension-manifests.sh
@@ -38,7 +38,7 @@ for manifest_path in "${MANIFEST_PATHS[@]}" ; do
 
     # Check latest commit for extension changes if forcible platform flag not set
     platform_manifest_path=$(dirname "$manifest_path" | sed 's|^\./||')
-    if [ "$chromium_only" != true ] && [ "$ff_only" != true ] ; then
+    if [[ ! "${chromium_only} ${ff_only}" =~ "true" ]] ; then
         echo "Checking last commit details for $platform_manifest_path..."
         latest_platform_commit_msg=$(git log -1 --format=%s -- "$platform_manifest_path")
         echo -e "${DG}${latest_platform_commit_msg}${NC}\n"

diff --git a/chatgpt-infinity/utils/bump/extension-manifests.sh b/chatgpt-infinity/utils/bump/extension-manifests.sh
@@ -38,7 +38,7 @@ for manifest_path in "${MANIFEST_PATHS[@]}" ; do
 
     # Check latest commit for extension changes if forcible platform flag not set
     platform_manifest_path=$(dirname "$manifest_path" | sed 's|^\./||')
-    if [ "$chromium_only" != true ] && [ "$ff_only" != true ] ; then
+    if [[ ! "${chromium_only} ${ff_only}" =~ "true" ]] ; then
         echo "Checking last commit details for $platform_manifest_path..."
         latest_platform_commit_msg=$(git log -1 --format=%s -- "$platform_manifest_path")
         echo -e "${DG}${latest_platform_commit_msg}${NC}\n"

diff --git a/chatgpt-widescreen/utils/bump/extension-manifests.sh b/chatgpt-widescreen/utils/bump/extension-manifests.sh
@@ -38,7 +38,7 @@ for manifest_path in "${MANIFEST_PATHS[@]}" ; do
 
     # Check latest commit for extension changes if forcible platform flag not set
     platform_manifest_path=$(dirname "$manifest_path" | sed 's|^\./||')
-    if [ "$chromium_only" != true ] && [ "$ff_only" != true ] ; then
+    if [[ ! "${chromium_only} ${ff_only}" =~ "true" ]] ; then
         echo "Checking last commit details for $platform_manifest_path..."
         latest_platform_commit_msg=$(git log -1 --format=%s -- "$platform_manifest_path")
         echo -e "${DG}${latest_platform_commit_msg}${NC}\n"

diff --git a/phind-omnibox/utils/bump.sh b/phind-omnibox/utils/bump.sh
@@ -38,7 +38,7 @@ for manifest_path in "${MANIFEST_PATHS[@]}" ; do
 
     # Check latest commit for extension changes if forcible platform flag not set
     platform_manifest_path=$(dirname "$manifest_path" | sed 's|^\./||')
-    if [ "$chromium_only" != true ] && [ "$ff_only" != true ] ; then
+    if [[ ! "${chromium_only} ${ff_only}" =~ "true" ]] ; then
         echo "Checking last commit details for $platform_manifest_path..."
         latest_platform_commit_msg=$(git log -1 --format=%s -- "$platform_manifest_path")
         echo -e "${DG}${latest_platform_commit_msg}${NC}\n"

diff --git a/utils/bump/extension-manifests.sh b/utils/bump/extension-manifests.sh
@@ -51,7 +51,7 @@ for project_name in "${SORTED_PROJECTS[@]}" ; do
 
         # Check latest commit for extension changes if forcible platform flag not set
         platform_manifest_path=$(dirname "$manifest_path" | sed 's|^\./||')
-        if [ "$chromium_only" != true ] && [ "$ff_only" != true ] ; then
+        if [[ ! "${chromium_only} ${ff_only}" =~ "true" ]] ; then
             echo "Checking last commit details for $platform_manifest_path..."
             latest_platform_commit_msg=$(git log -1 --format=%s -- "$platform_manifest_path")
             echo -e "${DG}${latest_platform_commit_msg}${NC}\n"

diff --git a/you.com-omnibox/utils/bump.sh b/you.com-omnibox/utils/bump.sh
@@ -38,7 +38,7 @@ for manifest_path in "${MANIFEST_PATHS[@]}" ; do
 
     # Check latest commit for extension changes if forcible platform flag not set
     platform_manifest_path=$(dirname "$manifest_path" | sed 's|^\./||')
-    if [ "$chromium_only" != true ] && [ "$ff_only" != true ] ; then
+    if [[ ! "${chromium_only} ${ff_only}" =~ "true" ]] ; then
         echo "Checking last commit details for $platform_manifest_path..."
         latest_platform_commit_msg=$(git log -1 --format=%s -- "$platform_manifest_path")
         echo -e "${DG}${latest_platform_commit_msg}${NC}\n"