Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running targets without exiting leaves the console screen buffer output mode changed #482

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

adamralph
Copy link
Owner

@adamralph adamralph commented Oct 6, 2020

Version(s)

1.2.0 to 3.5.0.

To reproduce

Steps to reproduce the behavior:

  1. Use Windows
  2. Ensure the console screen buffer output mode is set to something other than 7.
  3. Call RunTargetsWithoutExiting without the --no-color option.

Expected behavior

The console screen buffer output mode is the same as before calling the method.

Actual behaviour

The console screen buffer output mode is 7.

Workarounds

Record the original console screen buffer output mode before calling the method and reset it after calling the method.

@adamralph adamralph added the bug Something isn't working label Oct 6, 2020
@adamralph adamralph added this to the 3.6.0 milestone Oct 6, 2020
@adamralph adamralph marked this pull request as ready for review October 8, 2020 21:43
@adamralph adamralph changed the title running targets leaves console output mode changed running targets without exiting leaves the console screen buffer output mode changed Oct 8, 2020
@adamralph adamralph merged commit 9f5436c into master Oct 8, 2020
@adamralph adamralph deleted the reset-console branch October 8, 2020 22:17
@adamralph
Copy link
Owner Author

Released in 3.6.0-rc.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant