Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete the spread of the ConfigureAwait(false) virus #8

Merged
merged 1 commit into from
Nov 21, 2017
Merged

complete the spread of the ConfigureAwait(false) virus #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions Bullseye/Internal/DictionaryExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,25 +61,25 @@ public static async Task<int> RunAsync(this IDictionary<string, Target> targets,

if (unknownOptions.Any())
{
await console.Error.WriteLineAsync($"Unknown options {unknownOptions.Quote()}. \"--help\" for usage.");
await console.Error.WriteLineAsync($"Unknown options {unknownOptions.Quote()}. \"--help\" for usage.").ConfigureAwait(false);
return 1;
}

if (showHelp)
{
await console.Out.WriteLineAsync(GetUsage(options.NoColor));
await console.Out.WriteLineAsync(GetUsage(options.NoColor)).ConfigureAwait(false);
return 0;
}

if (listDependencies)
{
await console.Out.WriteLineAsync(targets.ToDependencyString(options.NoColor));
await console.Out.WriteLineAsync(targets.ToDependencyString(options.NoColor)).ConfigureAwait(false);
return 0;
}

if (listTargets)
{
await console.Out.WriteLineAsync(targets.ToListString());
await console.Out.WriteLineAsync(targets.ToListString()).ConfigureAwait(false);
return 0;
}

Expand All @@ -89,7 +89,7 @@ public static async Task<int> RunAsync(this IDictionary<string, Target> targets,
names.Add("default");
}

await console.Out.WriteLineAsync(names.ToTargetsRunning(options));
await console.Out.WriteLineAsync(names.ToTargetsRunning(options)).ConfigureAwait(false);
var stopWatch = Stopwatch.StartNew();

try
Expand All @@ -98,12 +98,12 @@ public static async Task<int> RunAsync(this IDictionary<string, Target> targets,
}
catch (Exception ex)
{
await console.Out.WriteLineAsync(names.ToTargetsFailed(options, stopWatch.Elapsed.TotalMilliseconds));
await console.Error.WriteLineAsync(ex.ToString());
await console.Out.WriteLineAsync(names.ToTargetsFailed(options, stopWatch.Elapsed.TotalMilliseconds)).ConfigureAwait(false);
await console.Error.WriteLineAsync(ex.ToString()).ConfigureAwait(false);
return 1;
}

await console.Out.WriteLineAsync(names.ToTargetsSucceeded(options, stopWatch.Elapsed.TotalMilliseconds));
await console.Out.WriteLineAsync(names.ToTargetsSucceeded(options, stopWatch.Elapsed.TotalMilliseconds)).ConfigureAwait(false);

return 0;
}
Expand Down Expand Up @@ -143,23 +143,23 @@ private static async Task RunAsync(this IDictionary<string, Target> targets, str

if (target.Action != default)
{
await console.Out.WriteLineAsync(name.ToTargetStarting(options));
await console.Out.WriteLineAsync(name.ToTargetStarting(options)).ConfigureAwait(false);
var stopWatch = Stopwatch.StartNew();

if (!options.DryRun)
{
try
{
await target.Action();
await target.Action().ConfigureAwait(false);
}
catch (Exception ex)
{
await console.Out.WriteLineAsync(name.ToTargetFailed(ex, options, stopWatch.Elapsed.TotalMilliseconds));
await console.Out.WriteLineAsync(name.ToTargetFailed(ex, options, stopWatch.Elapsed.TotalMilliseconds)).ConfigureAwait(false);
throw;
}
}

await console.Out.WriteLineAsync(name.ToTargetSucceeded(options, stopWatch.Elapsed.TotalMilliseconds));
await console.Out.WriteLineAsync(name.ToTargetSucceeded(options, stopWatch.Elapsed.TotalMilliseconds)).ConfigureAwait(false);
}
}

Expand Down