Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar 'command field' font is always dark #49

Closed
denlun opened this issue May 15, 2024 · 5 comments
Closed

Status bar 'command field' font is always dark #49

denlun opened this issue May 15, 2024 · 5 comments
Labels
bug Something isn't working
Milestone

Comments

@denlun
Copy link

denlun commented May 15, 2024

Not really sure if this is actually a problem with the majority of the terminal programs...
Have tried several different terminals and when a dark theme is used you cannot read the command field. The main issue is that many terminals do not honor the system color theme (at least in Gnome).
Gnome Terminal has to have theme set to light in Preferences (or leave it default if the system theme is light).
Rxvt defaults to a light theme so no issues out of the box.
Terminator defaults to dark, can't read.
Terminology defaults to dark, can't read.
Alacritty defaults to dark, can't read.
Kitty defaults to dark, can't read.
Funnily enough Cool Retro Term gets it right even tho it defaults to dark... and with the amber default it looks pretty much like Brief did back in the day on my Ericsson PC...
And another thing I noticed while trying out the terminals is that in many of them Grief tended to put the horizontal scroll bar one third of the screen up and with some odd line lengths, this corrected itself when resizing the window.

@adamyg
Copy link
Owner

adamyg commented May 20, 2024

"And another thing I noticed while trying out the terminals is that in many of them Grief tended to put the horizontal scroll bar one third of the screen up and with some odd line lengths, this corrected itself when resizing the window."

screen captures plus terminal and colorscheme details;
note: F10/colorscheme and F10/dispinfo, shall detail.
thanks

@adamyg
Copy link
Owner

adamyg commented May 20, 2024

Under WIN32/256, 16-colorscheme's are being incorrectly mapped.

@adamyg adamyg added this to the build-25 milestone May 20, 2024
@adamyg adamyg added the bug Something isn't working label May 20, 2024
@denlun
Copy link
Author

denlun commented May 21, 2024

Here is Terminator where Grief has been started without resizing the window.
terminator-grief

Note the lines with a '+' in the vertical scroll and also the horizontal scroll.
As soon as you resize the window it's corrected.

@adamyg
Copy link
Owner

adamyg commented May 22, 2024

Not familiar with, https://terminator-gtk3.readthedocs.io/en/latest/, what is the TERM setting in use?
Wondering what are the supported control-escapes, including "Device Attributes" report.
Run grief with -d enabled and forward the opening section of the log detailing the terminal.

Suspect its related to column wrap rules, as a test run with the terminal width > 80.,
Reference: https://www.gnu.org/software/termutils/manual/termcap-1.3/html_node/termcap_27.html

@denlun
Copy link
Author

denlun commented May 23, 2024

I verified the > 80 using GNOME Terminal since it happens there as well and seems if you set the startup width to 81 or greater the problem doesn't occur.
The TERM in GNOME Terminal and Terminator is the same: xterm-256color
grief.log

adamyg added a commit that referenced this issue Jun 9, 2024
* Update gr-inno-setup.iss

publish macsrc

* app manifest

* web reference

* uname window 11

* rm defunct function

* 2023

* msvc 19.34

* actions/checkout@v3

node.js upgrade

* actions/upload-artifact@v3

node.js upgrade

* mingw

* #29

* #33

* libz 1.2.13

* #27

* relpath operation

* typo

* unicode title save/restore

* formatting

* disable libicu

* 2023/merge

* libappupdater latest

* mingw

* mingw/libw32 upgrades

* duktape 2.7.0

* cachealignment

* BUILD_TOOLNAME

* merge

* 2024

* libw32 merge

* update

* merge

* merge

* WINNT tweaks

* optreset linkage

* WINVER

* latest

* x64 detection

* _M_X64 checks

* WINNT

* owc tweaks

* owc tweaks

* ignored

* Unicode issue

* ignore

* Source snapshot (non-win32)

* snapshot source directory

* snapshot working directory

* snapshot, exclude git

* tgz.zip

* package name

* packaging

* 2024

* objtree

* checkoutv4

* libappupdater, owc updates

* snapshot

* exclude-vcs

* 2024

* printable check

* 2024

* quickstart documentation

* updated

* quickstart

* quickstart

* configure/make upgrades

* configure/make upgrades

* latest

* #41

* #39

* #38

* autoconf curl.h

* ignore's

* 3.2.3

* msvc160+

* #44

* #41

* #36 and #28

* #46

* api changes

* Makefile/configure

* contrib

* openssl

* mingw

* OPENSSL

* cleanup

* cleanup

* ucs 15.1.0

* Update README.md

* README

* Coloriser 256 improvements

* Update README.md

* Update README.md

center images

* #49, apply eat_newline_glitch unconditionally

* license

* warning

* 2024

* doc updates

* byacc

* byacc

* byacc

* dependency

* documentation

* owc issues

* cleanup

* documentation

* build system

* documentation

* remove legacy components

* documentation

* remove legacy components

* macos builds

* macos builds

* libguess-1.2

* default to ncursesw

* standardised name

* cleanup

* configure

* warnings

* configure

* configure

* doc/packaging

* libiconv/citrus merge

* libiconv/citrus merge

* libiconv/citrus merge

* libiconv/citrus merge

* libteken merge

* cr syntax

* msvc1940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants