Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix baseline creation on linux-base systems #2063

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

adam-narozniak
Copy link
Member

Issue

Description

The create-baseline script doesn't fully work on Linux. It leads to sed: can't read : No such file or directory on linux - it doesn't change the name in pyproject.toml.

Related issues/PRs

NA

Proposal

Explanation

The sed works slightly differently on Mac and Linux. The fix causes the script to work differently on Linux and Mac.

@adam-narozniak adam-narozniak marked this pull request as ready for review July 7, 2023 11:23
@adam-narozniak adam-narozniak enabled auto-merge (squash) July 7, 2023 11:23
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

@adam-narozniak adam-narozniak merged commit b5f0fc5 into main Jul 7, 2023
@adam-narozniak adam-narozniak deleted the fix-baseline-creation branch July 7, 2023 12:04
tanertopal added a commit that referenced this pull request Jul 11, 2023
* main:
  Add new baselines test github workflow (#2009)
  Add simulation to E2E tests (#2074)
  Add E2E test for Pandas (#2070)
  Add E2E test for scikit-learn (#2073)
  Add format and test scripts (#1987)
  Add missing ruff dependency to baselines (#2075)
  Add E2E test for MXNet (#2069)
  Add E2E test for Jax (#2067)
  Update bare E2E test client (#2068)
  Update PyTorch E2E test (#2072)
  Update Tensorflow E2E test (#2071)
  Fix flake8 error E266 in baseline template (#2065)
  Fix baseline creation on linux-based systems (#2063)
  Updates to Baseline Template Readmes (#2059)
  Refresh FedProx MNIST baseline (#1918)
  Extend test checking tools config (#1986)
  Improved documentation (#2006)
  updated material for 30min FL tutorial (#2005)
  Update codeowners list (#2004)
  Create and delete nodes via Fleet API (#1901)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants