Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework:skip) Remove pydantic from list of extras in pyproject.toml #3514

Merged
merged 2 commits into from
May 27, 2024

Conversation

jafermarq
Copy link
Contributor

It was added first here last year due to an issue with Ray (#2002), but it got removed from the dependencies list last month (#3265). It doesn't seem to be needed anymore?

@danieljanes danieljanes marked this pull request as ready for review May 27, 2024 09:53
@danieljanes danieljanes requested a review from tanertopal as a code owner May 27, 2024 09:53
@danieljanes danieljanes enabled auto-merge (squash) May 27, 2024 09:54
@danieljanes danieljanes disabled auto-merge May 27, 2024 09:56
@danieljanes danieljanes changed the title feat(*:skip) Remove pydantic from list of extras in pyproject.toml fix(*:skip) Remove pydantic from list of extras in pyproject.toml May 27, 2024
@danieljanes danieljanes changed the title fix(*:skip) Remove pydantic from list of extras in pyproject.toml fix(framework:skip) Remove pydantic from list of extras in pyproject.toml May 27, 2024
@danieljanes danieljanes enabled auto-merge (squash) May 27, 2024 09:57
@danieljanes danieljanes merged commit 2e1d943 into main May 27, 2024
31 checks passed
@danieljanes danieljanes deleted the remove-pydantic-extra branch May 27, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants