Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shared parameters module in model mixin #440

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Fix shared parameters module in model mixin #440

merged 1 commit into from
Oct 26, 2022

Conversation

calpt
Copy link
Member

@calpt calpt commented Oct 25, 2022

This PR fixes with model classes not being able to access the shared parameters of compacter modules e.g. during sequence generation.

@calpt calpt marked this pull request as ready for review October 25, 2022 09:12
@calpt calpt requested a review from hSterz October 25, 2022 09:12
@calpt calpt merged commit 5df99d4 into adapter-hub:master Oct 26, 2022
@calpt calpt deleted the fix/compacter_shared_params branch October 26, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hSterz hSterz hSterz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calpt @hSterz