Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: aria label added for partly correct answers (fixes #553) #554

Merged
merged 2 commits into from
Jun 11, 2024
Merged

New: aria label added for partly correct answers (fixes #553) #554

merged 2 commits into from
Jun 11, 2024

Conversation

kirsty-hames
Copy link
Contributor

Fixes #553

New

Requires answeredPartlyCorrect aria label added to course _globals (FW PR adaptlearning/adapt_framework#3570).

Testing

You can test the following either by running a screen reader or inspect the button marking label .js-btn-marking-label (button marking displays bewteen the show answer / feedback buttons.

  1. Test with FW branch issue/3565
  2. Using the Adapt course, go to Matching component c-225.
  3. Answer the Matching component as per below to test correct, partially correct and incorrect aria labels are used.
  • correct answers - item 1: 2013, item 2: 2008, item 3: Hebrew
  • partly correct answers - item 1: 2013, item 2: 2013, item 3: Esperanto
  • incorrect answer - item 1: 2008, item 2: 2013, item 3: Esperanto

@kirsty-hames kirsty-hames self-assigned this Jun 10, 2024
@kirsty-hames kirsty-hames added enhancement New feature or request accessibility labels Jun 10, 2024
oliverfoster
oliverfoster requested changes Jun 10, 2024
View reviewed changes
js/views/buttonsView.js Outdated Show resolved Hide resolved
@kirsty-hames @oliverfoster
default to answeredIncorrectly if answeredPartlyCorrect doesn't exist
ec043c4 
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 45b8818 into master Jun 11, 2024
@oliverfoster oliverfoster deleted the issue/553 branch June 11, 2024 08:44
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
@semantic-release-bot
Chore(release): 6.51.0
4c2b594 
# [6.51.0](v6.50.2...v6.51.0) (2024-06-11)

### New

* Aria label added for partly correct answers (fixes #553) (#554) ([45b8818](45b8818)), closes [#553](#553) [#554](#554)
@oliverfoster
Copy link
Member

🎉 This PR is included in version 6.51.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@chris-steele chris-steele chris-steele approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create aria label for partly correct answers
4 participants
@kirsty-hames @oliverfoster @chris-steele @cahirodoherty-learningpool