Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added _canShowCorrectness and .can-show-correctness for questions #582

Merged
merged 2 commits into from
Oct 4, 2024
Merged

New: Added _canShowCorrectness and .can-show-correctness for questions #582

merged 2 commits into from
Oct 4, 2024

Conversation

oliverfoster
Copy link
Member

part of adaptlearning/adapt_framework#3597

New

  • Added _canShowCorrectness and .can-show-correctness for questions

@oliverfoster oliverfoster self-assigned this Sep 10, 2024
kirsty-hames
kirsty-hames approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected thanks. _canShowCorrectness takes precedence over _canShowModelAnswer when both are set to true.

joe-allen-89
joe-allen-89 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This was referenced Sep 12, 2024
Merged
Merged
This was referenced Sep 18, 2024
Merged
Merged
@oliverfoster oliverfoster mentioned this pull request Oct 1, 2024
Merged
@simondate simondate self-requested a review October 3, 2024 16:00
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit c5668ac into master Oct 4, 2024
@joe-allen-89 joe-allen-89 deleted the issue/3597 branch October 4, 2024 16:06
github-actions bot pushed a commit that referenced this pull request Oct 4, 2024
@semantic-release-bot
Chore(release): 6.56.0
80e2ac1 
# [6.56.0](v6.55.0...v6.56.0) (2024-10-04)

### New

* Added _canShowCorrectness and .can-show-correctness for questions (fixes #582) ([c5668ac](c5668ac)), closes [#582](#582)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.56.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@simondate simondate simondate approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oliverfoster @simondate @kirsty-hames @cahirodoherty-learningpool @joe-allen-89