Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing properties #305

Closed
swashbuck opened this issue May 13, 2024 · 1 comment · Fixed by #306
Closed

Add missing properties #305

swashbuck opened this issue May 13, 2024 · 1 comment · Fixed by #306
Assignees
@swashbuck
Labels
bug released

Comments

@swashbuck
Copy link
Contributor

Subject of the issue

There are a few Narrative properties missing from the schemas and/or documentation. With the schemas, this means that those features are not available in the AAT.

example.json

  • _isMobileTextBelowImage
  • _isStackedOnMobile

Legacy schemas

  • _isStackedOnMobile

V1 schemas

  • _isMobileTextBelowImage
  • _isStackedOnMobile

These should be added with a note that they only apply when _isNarrativeOnMobile is true.

Your environment

  • Hot Graphic v6.12.0
@swashbuck swashbuck added the bug label May 13, 2024
@swashbuck swashbuck self-assigned this May 13, 2024
@swashbuck swashbuck mentioned this issue May 13, 2024
Merged
swashbuck added a commit that referenced this issue May 17, 2024
@swashbuck
Fix: Add missing properties to schemas and documentation (fixes #305)
d966174
github-actions bot pushed a commit that referenced this issue May 17, 2024
@semantic-release-bot
Chore(release): 6.12.1 [skip ci]
ac45457 
## [6.12.1](v6.12.0...v6.12.1) (2024-05-17)

### Fix

* Add missing properties to schemas and documentation (fixes #305) ([d966174](d966174)), closes [#305](#305)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 6.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Add missing properties (fixes #305) adaptlearning/adapt-contrib-hotgraphic
1 participant
@swashbuck