Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allow additional custom classes on tooltips (fixes #316) #317

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Fix: Allow additional custom classes on tooltips (fixes #316) #317

merged 6 commits into from
Sep 30, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Sep 10, 2024 •
edited by kirsty-hames
Loading

Fix #316

Fix

  • Allows additional custom classes on tooltips

Testing

  1. In a Hot Graphic, set "_hasStaticTooltips": true
  2. For an item _tooltip, add some custom classes:
"_tooltip": {
  "_isEnabled": true,
  "text": "{{ariaLabel}}",
  "_classes": "text-white text-larger"
}
  1. Ensure that the tooltip's style does not change.

@swashbuck swashbuck self-assigned this Sep 10, 2024
oliverfoster
oliverfoster reviewed Sep 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@swashbuck @oliverfoster
Update README.md
ef10d20 
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
oliverfoster
oliverfoster reviewed Sep 16, 2024
View reviewed changes
js/hotgraphicModel.js Outdated Show resolved Hide resolved
@swashbuck @oliverfoster
Update js/hotgraphicModel.js
7e4c1ec 
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
kirsty-hames
kirsty-hames approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition thanks @swashbuck and works as expected

js/hotgraphicModel.js Outdated Show resolved Hide resolved
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit af89644 into master Sep 30, 2024
@oliverfoster oliverfoster deleted the issue/316 branch September 30, 2024 14:34
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
@semantic-release-bot
Chore(release): 6.13.5 [skip ci]
480429a 
## [6.13.5](v6.13.4...v6.13.5) (2024-09-30)

### Fix

* Allow additional custom classes on tooltips (fixes #316) (#317) ([af89644](af89644)), closes [#316](#316) [#317](#317)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.13.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom Tooltip classes
4 participants
@swashbuck @kirsty-hames @oliverfoster @cahirodoherty-learningpool