Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Add has-numbered-pins class when using numbered pins (fix #320) #321

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Update: Add has-numbered-pins class when using numbered pins (fix #320) #321

merged 4 commits into from
Sep 30, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Sep 27, 2024 •
edited
Loading

Fixes #320

Fix

  • Fix typo in PR template
  • Add line breaks to readme

Update

  • Adds is-numbered-pin class when using numbered pins

Testing

  1. Enable _useNumberedPins on a Hot Graphic.
  2. Inspect the .hotgraphic__pin elements and ensure the new class is present.

@swashbuck swashbuck self-assigned this Sep 27, 2024
joe-allen-89
joe-allen-89 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kirsty-hames
kirsty-hames reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition thanks @swashbuck.

Should .has-numbered-pins be exclusive to the standard configuration only (clickable 'pin' icons overlaying the main image)? The other two layouts, custom pin image and _useGraphicsAsPins don't display number pins and already have their own set styles. Potentially there could be a conflict of styles but seeing as we're not attaching any styles to .has-numbered-pins then happy to leave as is for developers to address in their own custom styles.

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck
Copy link
Contributor Author

Should .has-numbered-pins be exclusive to the standard configuration only (clickable 'pin' icons overlaying the main image)?

@kirsty-hames That makes sense. I've moved the class to the pin buttons themselves and changed the name to is-numbered-pin.

@oliverfoster oliverfoster merged commit f572710 into master Sep 30, 2024
@oliverfoster oliverfoster deleted the issue/320 branch September 30, 2024 14:42
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
@semantic-release-bot
Chore(release): 6.14.0 [skip ci]
2dc6cd9 
# [6.14.0](v6.13.5...v6.14.0) (2024-09-30)

### Update

* Add has-numbered-pins class when using numbered pins (fix #320) (#321) ([f572710](f572710)), closes [#320](#320) [#321](#321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add class when using numbered pins
5 participants
@swashbuck @kirsty-hames @oliverfoster @cahirodoherty-learningpool @joe-allen-89