Fix: Removed select on focus behaviour allowed space and enter for selection

[oliverfoster]

fixes #229

This should fix ios voiceover selection issues on radio (single select) mcqs and gmcqs

Reference: https://www.w3.org/WAI/ARIA/apg/patterns/radio/

Fix

• Remove select on focus
• Allow both space and enter to toggle
• Deprecated onKeyPress for onKeyDown

[swashbuck]

@oliverfoster The keyPress event is deprecated. Can you switch it to the keyDown event and rename the function?

adapt-contrib-mcq/templates/mcq.jsx

Line 72 in 13ca7d2

onKeyPress={onKeyPress}

[swashbuck]

👍 Tested iPhone 13 with VoiceOver iOS

[cahirodoherty-learningpool]

👀

[kirsty-hames]

This works as expected for single select (radio) MCQs however multi select (checkbox) MCQs no longer allow you to toggle selection with space. Enter works fine.

When pressing space, the previous selection is unchecked but the focused item isn't checked. You get an intermittent flash of a selection.

Testing with Safari on Mac.

[oliverfoster]

Cool, thanks @kirsty-hames

[oliverfoster]

Space was triggering both a keydown and change event on the checkbox. I've got the keydown to prevent default so that the change event doesn't trigger in that eventuality.

[kirsty-hames]

Thanks @oliverfoster - both space and enter toggle selection 👍

[github-actions]

🎉 This PR is included in version 7.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀