Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ariaQuestion placeholder text #196

Closed
kirsty-hames opened this issue Nov 20, 2023 · 1 comment · Fixed by #197
Closed

Remove ariaQuestion placeholder text #196

kirsty-hames opened this issue Nov 20, 2023 · 1 comment · Fixed by #197
Assignees
@kirsty-hames
Labels
accessibility released

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

As per global question component issue adaptlearning/adapt-contrib-mcq#211.

Remove example placeholder text for ariaQuestion to prevent placeholder text being copied over and left in accessible courses.

ariaQuestion property description is noted in README and schema help/description for reference.
@kirsty-hames kirsty-hames self-assigned this Nov 20, 2023
@kirsty-hames kirsty-hames moved this from New to Assigned in adapt_framework: The TODO Board Nov 20, 2023
@kirsty-hames kirsty-hames mentioned this issue Nov 20, 2023
Merged
@kirsty-hames kirsty-hames moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Nov 20, 2023
kirsty-hames added a commit that referenced this issue Nov 22, 2023
@kirsty-hames
Update: remove ariaQuestion placeholder text (fixes #196) #197
832bd98
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Nov 22, 2023
github-actions bot pushed a commit that referenced this issue Nov 22, 2023
@semantic-release-bot
Chore(release): 4.5.0 [skip ci]
288880d 
# [4.5.0](v4.4.0...v4.5.0) (2023-11-22)

### Update

* remove ariaQuestion placeholder text (fixes #196) #197 ([832bd98](832bd98)), closes [#196](#196) [#197](#197)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 4.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: Remove ariaQuestion placeholder text (fixes #196) adaptlearning/adapt-contrib-slider
1 participant
@kirsty-hames