-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing default attribute values can cause range input display issues or runtime errors #204
Labels
Comments
danielghost
added a commit
that referenced
this issue
May 21, 2024
…d `_scaleStep`. Changed `_scaleEnd` schema default from 1 to 10. (fixes #204).
danielghost
moved this from Assigned
to Needs Reviewing
in adapt_framework: The TODO Board
May 21, 2024
joe-allen-89
pushed a commit
that referenced
this issue
May 29, 2024
* Fix: added default attribute values for `_scaleStart`, `_scaleEnd` and `_scaleStep`. Changed `_scaleEnd` schema default from 1 to 10. (fixes #204). * Removed `_scaleStep` fallbacks as these are no longer needed with a default model value. * Restrict `_scaleStep` to a positive number, to prevent errors.
github-project-automation
bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As there is no default value for
_scaleStart
and_scaleEnd
, the following error will occur if either are omitted from the JSON:For a confidence slider the runtime error isn't immediately shown, but a missing
_scaleStart
(if using_linkedToId
it will attempt to retrieve these values from the linked model) causes the input display to be out of sync with the value (presumably because it defaults to the default 0min
of<input type="range">
. If_scaleEnd
is missing the scale is displayed incorrectly and the following error occurs when interacting with the slider:The schema default for
_scaleEnd
should also be changed from 1.The text was updated successfully, but these errors were encountered: