Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Incorrect return early logic in onButtonsViewPostRender (fixes #102) #103

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Fix: Incorrect return early logic in onButtonsViewPostRender (fixes #102) #103

merged 2 commits into from
Aug 11, 2023

Conversation

joe-allen-89
Copy link
Contributor

#102

Fix

@joe-allen-89 joe-allen-89 self-assigned this Aug 10, 2023
@joe-allen-89 joe-allen-89 linked an issue Aug 10, 2023 that may be closed by this pull request
Tutor "inline" fails to modify buttons #102
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

chucklorenz
chucklorenz reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@chucklorenz chucklorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'.asString' appears on line 23 as part of getTutorType().
Is it more appropriate to remove it from line 23 rather than add it again in line 40?

@joe-allen-89
Copy link
Contributor Author

'.asString' appears on line 23 as part of getTutorType(). Is it more appropriate to remove it from line 23 rather than add it again in line 40?

Good point @chucklorenz, it does look cleaner without. Also removed from line 31.

chucklorenz
chucklorenz approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@chucklorenz chucklorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit b8f1844 into master Aug 11, 2023
@joe-allen-89 joe-allen-89 deleted the issue/102 branch August 11, 2023 08:37
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
@semantic-release-bot
Chore(release): 4.5.9 [skip ci]
ae525c0 
## [4.5.9](v4.5.8...v4.5.9) (2023-08-11)

### Chore

* Semantic release GHA packages version bump (#99) ([ffc89fc](ffc89fc)), closes [#99](#99)

### Fix

* Incorrect return early logic in onButtonsViewPostRender (fixes #102) (#103) ([b8f1844](b8f1844)), closes [#102](#102) [#103](#103)
@github-actions
Copy link

🎉 This PR is included in version 4.5.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@chucklorenz chucklorenz chucklorenz approved these changes

@oliverfoster oliverfoster Awaiting requested review from oliverfoster

Assignees

@joe-allen-89 joe-allen-89

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tutor "inline" fails to modify buttons
4 participants
@joe-allen-89 @chucklorenz @cahirodoherty-learningpool @eleanor-heath