Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt:initialize called before plugins have chance to complete aysnc ops during app:dataReady #1536

Closed
chris-steele opened this issue Apr 22, 2017 · 2 comments
Closed

adapt:initialize called before plugins have chance to complete aysnc ops during app:dataReady #1536

chris-steele opened this issue Apr 22, 2017 · 2 comments

Comments

@chris-steele
Copy link
Contributor

chris-steele commented Apr 22, 2017 •
edited
Loading

Causes problems such as restoring user answers: QuestionModel listens for adapt:initialize, but because adapt-contrib-spoor performs operations on app:dataReady asynchronously, this means data is not necessarily ready in time.
chris-steele added a commit that referenced this issue Apr 22, 2017
@chris-steele
Fix for issue #1536
68ba62e
@chris-steele
Copy link
Contributor Author

Accidentally pushed this directly to master. If that's a problem I can revert, but this is a pretty simple yet critical fix.

chris-steele added a commit that referenced this issue Apr 23, 2017
@chris-steele
Fix for issue #1536
913f9dc
@chris-steele
Copy link
Contributor Author

@oliverfoster Couldn't live with the guilt. I've moved changes from master to issue/#1536, if you could have a look that would be awesome 👍

@chris-steele chris-steele mentioned this issue Apr 23, 2017
Merged
oliverfoster added a commit that referenced this issue May 18, 2017
@oliverfoster
Merge branch 'master' into issue/#1536
58c2194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomgreenfield @chris-steele