Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn if incompatible plugins are being compiled #3321

Closed
oliverfoster opened this issue May 4, 2022 · 2 comments · Fixed by #3528
Closed

warn if incompatible plugins are being compiled #3321

oliverfoster opened this issue May 4, 2022 · 2 comments · Fixed by #3528
Assignees
@swashbuck
Labels
bug released

Comments

@oliverfoster
Copy link
Member

plugin package.json:framework vs framework package.json and warn if semver doesn't match
@oliverfoster oliverfoster transferred this issue from adaptlearning/adapt-cli Aug 8, 2022
@oliverfoster oliverfoster moved this from New to Assigned in adapt_framework: The TODO Board Aug 8, 2022
@oliverfoster oliverfoster self-assigned this Aug 8, 2022
@oliverfoster oliverfoster mentioned this issue Sep 15, 2023
Merged
@oliverfoster
Copy link
Member Author

oliverfoster commented Mar 11, 2024 •
edited
Loading

@swashbuck could you also pick this up whilst you're in here #3527 ?

semver will need installing at the package.json.

@swashbuck swashbuck assigned swashbuck and unassigned oliverfoster Mar 11, 2024
@swashbuck swashbuck mentioned this issue Mar 12, 2024
Merged
@swashbuck swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Mar 12, 2024
swashbuck added a commit that referenced this issue Mar 18, 2024
@swashbuck
Fix: Warn if incompatible plugins are being compiled (fixes #3321)
1108211
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 18, 2024
github-actions bot pushed a commit that referenced this issue Mar 18, 2024
@semantic-release-bot
Chore(release): 5.37.4 [skip ci]
df58ca4 
## [5.37.4](v5.37.3...v5.37.4) (2024-03-18)

### Fix

* Warn if incompatible plugins are being compiled (fixes #3321) ([1108211](1108211)), closes [#3321](#3321)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 5.37.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

VadirajJoshi-Laerdal added a commit to Laerdal/adapt_framework that referenced this issue Apr 1, 2024
@VadirajJoshi-Laerdal @oliverfoster
@olivermartinfoster @semantic-release-bot @guywillis @joe-allen-89 @cahirodoherty-learningpool @swashbuck @dependabot @lemmyadams
Merging adapt framwork into laerdal forked adapt framework - v5.36.2 …
b0832f5 
…---> v5.37.6 (#3)

* Fix: eslinting for cypress (fixes adaptlearning#3521) (adaptlearning#3522)

* Fix: eslinting for cypress (fixes adaptlearning#3521)

* Added package-lock.json

---------

Co-authored-by: Oliver Foster <olivermartinfoster@gmail.com>

* Chore(release): 5.36.3 [skip ci]

## [5.36.3](adaptlearning/adapt_framework@v5.36.2...v5.36.3) (2024-03-04)

### Fix

* eslinting for cypress (fixes adaptlearning#3521) (adaptlearning#3522) ([86d6f75](adaptlearning@86d6f75)), closes [adaptlearning#3521](adaptlearning#3521) [adaptlearning#3522](adaptlearning#3522) [adaptlearning#3521](adaptlearning#3521)

* New: Added `_iconClass` and `_position` properties (fixes adaptlearning#3512 fixes adaptlearning#3397) (adaptlearning#3513)

* Added `_iconClass` property

* Added `_position` property

---------

Co-authored-by: joe-allen-89 <85872286+joe-allen-89@users.noreply.github.com>

* Chore(release): 5.37.0 [skip ci]

# [5.37.0](adaptlearning/adapt_framework@v5.36.3...v5.37.0) (2024-03-04)

### New

* Added `_iconClass` and `_position` properties (fixes adaptlearning#3512 fixes adaptlearning#3397) (adaptlearning#3513) ([1ad8112](adaptlearning@1ad8112)), closes [adaptlearning#3512](adaptlearning#3512) [adaptlearning#3397](adaptlearning#3397) [adaptlearning#3513](adaptlearning#3513)

* Fix: Bumping core to v6.45.7 automatically via 'frameworkpullrequest' Github action (adaptlearning#3525)

Co-authored-by: oliverfoster <oliverfoster@users.noreply.github.com>

* Chore(release): 5.37.1 [skip ci]

## [5.37.1](adaptlearning/adapt_framework@v5.37.0...v5.37.1) (2024-03-04)

### Fix

* Bumping core to v6.45.7 automatically via 'frameworkpullrequest' Github action (adaptlearning#3525) ([2ed1ef4](adaptlearning@2ed1ef4)), closes [adaptlearning#3525](adaptlearning#3525)

* Chore: Bumping versions for GHA packages (adaptlearning#3524)

* Fix: Bumping core to v6.45.8 automatically via 'frameworkpullrequest' Github action (adaptlearning#3530)

Co-authored-by: oliverfoster <oliverfoster@users.noreply.github.com>

* Chore(release): 5.37.2 [skip ci]

## [5.37.2](adaptlearning/adapt_framework@v5.37.1...v5.37.2) (2024-03-18)

### Chore

* Bumping versions for GHA packages (adaptlearning#3524) ([11d5f1e](adaptlearning@11d5f1e)), closes [adaptlearning#3524](adaptlearning#3524)

### Fix

* Bumping core to v6.45.8 automatically via 'frameworkpullrequest' Github action (adaptlearning#3530) ([d7bf1be](adaptlearning@d7bf1be)), closes [adaptlearning#3530](adaptlearning#3530)

* Fix: Add plugin name to "unknown plugin type" error message (fixes adaptlearning#3526)

* Chore(release): 5.37.3 [skip ci]

## [5.37.3](adaptlearning/adapt_framework@v5.37.2...v5.37.3) (2024-03-18)

### Fix

* Add plugin name to "unknown plugin type" error message (fixes adaptlearning#3526) ([edeef52](adaptlearning@edeef52)), closes [adaptlearning#3526](adaptlearning#3526)

* Fix: Warn if incompatible plugins are being compiled (fixes adaptlearning#3321)

* Chore(release): 5.37.4 [skip ci]

## [5.37.4](adaptlearning/adapt_framework@v5.37.3...v5.37.4) (2024-03-18)

### Fix

* Warn if incompatible plugins are being compiled (fixes adaptlearning#3321) ([1108211](adaptlearning@1108211)), closes [adaptlearning#3321](adaptlearning#3321)

* Upgrade: Bump follow-redirects from 1.15.4 to 1.15.6 (adaptlearning#3529)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix: Bumping core to v6.46.1 automatically via 'frameworkpullrequest' Github action (adaptlearning#3531)

Co-authored-by: oliverfoster <oliverfoster@users.noreply.github.com>

* Chore(release): 5.37.5 [skip ci]

## [5.37.5](adaptlearning/adapt_framework@v5.37.4...v5.37.5) (2024-03-26)

### Fix

* Bumping core to v6.46.1 automatically via 'frameworkpullrequest' Github action (adaptlearning#3531) ([27b26fc](adaptlearning@27b26fc)), closes [adaptlearning#3531](adaptlearning#3531)

### Upgrade

* Bump follow-redirects from 1.15.4 to 1.15.6 (adaptlearning#3529) ([a947569](adaptlearning@a947569)), closes [adaptlearning#3529](adaptlearning#3529)

* Added striphtml and button cy functions

* Adjusted html func and added dynamic text lng

* Fix: Bumping core to v6.46.2 automatically via 'frameworkpullrequest' Github action (adaptlearning#3534)

Co-authored-by: oliverfoster <oliverfoster@users.noreply.github.com>

* Chore(release): 5.37.6 [skip ci]

## [5.37.6](adaptlearning/adapt_framework@v5.37.5...v5.37.6) (2024-03-27)

### Fix

* Bumping core to v6.46.2 automatically via 'frameworkpullrequest' Github action (adaptlearning#3534) ([93cf9a7](adaptlearning@93cf9a7)), closes [adaptlearning#3534](adaptlearning#3534)

* Removed buttons and added helper file

* removed function assignment

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
Co-authored-by: Oliver Foster <olivermartinfoster@gmail.com>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: Guy Willis <guywillis@users.noreply.github.com>
Co-authored-by: joe-allen-89 <85872286+joe-allen-89@users.noreply.github.com>
Co-authored-by: oliverfoster <oliverfoster@users.noreply.github.com>
Co-authored-by: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com>
Co-authored-by: Brad Simpson <brad.simpson@kineo.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lemmy Adams <lemmy.adams@learningpool.com>
Co-authored-by: Lemmy Adams <103187526+lemmyadams@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Warn if incompatible plugins are being compiled (fixes #3321) adaptlearning/adapt_framework
2 participants
@swashbuck @oliverfoster