-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ESC key to dismiss modal popups #938
Comments
I seem to recall this couldn't be done on account of ESC being a special key for screen readers... I thought perhaps I saw a PR for enabling it when accessibility wasn't active though, might be wrong |
ah, it was for closing the drawer see #612 |
this line for drawer https://github.com/adaptlearning/adapt_framework/blame/master/src/core/js/views/drawerView.js#L39 needs to be _isActive rather than _isEnabled, like e9b7f9d |
I think that's everything now? |
allow drawer to be closed by Esc keypress
added to hotgraphic in v2.0.7 |
Thinking of things like the tutor, hotgraphic items, etc., it would be useful if the ESC key could dismiss these and return to the course. It's quite a common behaviour now, e.g. Gitter, Slack, etc.
The text was updated successfully, but these errors were encountered: