Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ESC key to dismiss modal popups #938

Closed
brian-learningpool opened this issue Feb 11, 2016 · 5 comments
Closed

Allow ESC key to dismiss modal popups #938

brian-learningpool opened this issue Feb 11, 2016 · 5 comments
Assignees

Comments

@brian-learningpool
Copy link
Member

Thinking of things like the tutor, hotgraphic items, etc., it would be useful if the ESC key could dismiss these and return to the course. It's quite a common behaviour now, e.g. Gitter, Slack, etc.

@moloko
Copy link
Contributor

moloko commented Feb 11, 2016

I seem to recall this couldn't be done on account of ESC being a special key for screen readers... I thought perhaps I saw a PR for enabling it when accessibility wasn't active though, might be wrong

@moloko
Copy link
Contributor

moloko commented Feb 11, 2016

ah, it was for closing the drawer see #612

@oliverfoster
Copy link
Member

this line for drawer https://github.com/adaptlearning/adapt_framework/blame/master/src/core/js/views/drawerView.js#L39 needs to be _isActive rather than _isEnabled, like e9b7f9d

@moloko
Copy link
Contributor

moloko commented May 23, 2016

I think that's everything now?

himanshu1618 pushed a commit that referenced this issue May 24, 2016
allow drawer to be closed by Esc keypress
@moloko
Copy link
Contributor

moloko commented Jul 12, 2016

added to hotgraphic in v2.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants