Chore: Added menu page e2e tests (Issue/3468) #3469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemmyadams
requested review from
cahirodoherty-learningpool,
ethan-lp and
eleanor-heath
ethan-lp
approved these changes
Oct 5, 2023
eleanor-heath
approved these changes
Oct 5, 2023
oliverfoster
reviewed
Oct 6, 2023
test/e2e/menuPage.cy.js
Outdated
Comment on lines
9
to
26
| it(`should have the title '${Course.displayTitle}' and correct description`, () => { | ||
| cy.get('.menu__title-inner').should('contain', Course.displayTitle); | ||
| cy.get('.menu__body-inner').should('contain', Course.body); | ||
| }); | ||
|
|
||
| it(`should display ${Content.length} menu tiles`, () => { | ||
| cy.get('.menu-item').should('have.length', Content.length) | ||
|
|
||
| cy.get('.menu-item').each(($item, index) => { | ||
| cy.get($item).within(() => { | ||
| cy.get('.menu-item__title').should('contain', Content[index].displayTitle) | ||
| cy.get('.menu-item__body').should('contain', Content[index].body) | ||
| cy.get('button').should('contain', Content[index].linkText) | ||
| cy.get('.menu-item__duration').should('contain', Content[index].duration) | ||
| cy.get('img.menu-item__image').should('exist').should('have.attr', 'src', Content[index]._graphic.src) | ||
| }) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
This should really live in adapt-contrib-boxmenu
There was a problem hiding this comment.
I mean that it should live in the plugin adapt-contrib-boxmenu repo, not in the adapt_framework repo
oliverfoster
reviewed
Oct 6, 2023
test/e2e/menuPage.cy.js
Outdated
Comment on lines
28
to
41
| it('should have an expandable drawer', () => { | ||
| cy.get('.drawer[aria-expanded="true"]').should('not.exist') | ||
| cy.get('.drawer[aria-expanded="false"]').should('exist') | ||
|
|
||
| cy.get('button[data-event="toggleDrawer"]').click() | ||
|
|
||
| cy.get('.drawer[aria-expanded="true"]').should('exist') | ||
| cy.get('.drawer[aria-expanded="false"]').should('not.exist') | ||
|
|
||
| cy.get('button.drawer__close-btn').click() | ||
|
|
||
| cy.get('.drawer[aria-expanded="true"]').should('not.exist') | ||
| cy.get('.drawer[aria-expanded="false"]').should('exist') | ||
| }) |
There was a problem hiding this comment.
This should be in a drawer.cy.js file, or in adapt-contrib-resources, it's very difficult to know if the course has a drawer unless a plugin which requires the drawer is installed.
|
New data loading needs to be implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses adaptlearning/adapt-contrib-boxMenu#167