Merge pull request grpc-ecosystem#319 from campoy/master

Do not ignore the error coming from http.ListenAndServe in examples
adasari · Feb 28, 2017 · 25efc48 · 25efc48
2 parents 6b88bed + be77ba5
commit 25efc48
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -130,6 +130,7 @@ Make sure that your `$GOPATH/bin` is in your `$PATH`.
    Now you need to write an entrypoint of the proxy server.
    ```go
    package main
+
    import (
      "flag"
      "net/http"
@@ -158,8 +159,7 @@ Make sure that your `$GOPATH/bin` is in your `$PATH`.
        return err
      }
 
-     http.ListenAndServe(":8080", mux)
-     return nil
+     return http.ListenAndServe(":8080", mux)
    }
 
    func main() {

diff --git a/examples/main.go b/examples/main.go
@@ -96,8 +96,7 @@ func Run(address string, opts ...runtime.ServeMuxOption) error {
 	}
 	mux.Handle("/", gw)
 
-	http.ListenAndServe(address, allowCORS(mux))
-	return nil
+	return http.ListenAndServe(address, allowCORS(mux))
 }
 
 func main() {