-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate more tests to vitest-browser-react
and browserUserEvent
#3636
Conversation
vitest-browser-react
and browserUserEvent
vitest-browser-react
and browserUserEvent
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3636 +/- ##
==========================================
+ Coverage 91.89% 93.68% +1.79%
==========================================
Files 48 48
Lines 3453 3453
Branches 692 705 +13
==========================================
+ Hits 3173 3235 +62
+ Misses 280 218 -62
|
vitest-browser-react
and browserUserEvent
vitest-browser-react
and browserUserEvent
}); | ||
|
||
test('sortPriority defined using both providers', async () => { | ||
setupProvider({ columns, rows: noRows }); | ||
|
||
const [, headerCell2, headerCell3] = getHeaderCells(); | ||
const user = userEvent.setup(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await userEvent.click(getCellsAtRowIndex(0)[0]); | ||
setupNew(); | ||
await testSelection(0, false); | ||
await userEvent.click(getCellsAtRowIndexNew(0)[0]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This selects the checkbox now
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
I will rename utils in the next PR and migrate remaining test after that