Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing credits with the EPG data #54

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Allow passing credits with the EPG data #54

merged 1 commit into from
Nov 11, 2020

Conversation

michaelarnauts
Copy link
Contributor

@michaelarnauts michaelarnauts commented Nov 11, 2020

Allow to pass credits to the EPG data

An optional list of credits can be supplied for a program. A credit is an object with the property type that can be actor, director, writer, adapter, producer, composer, editor, presenter, commentator or guest, and a property name that contains the name of the person. For the type actor, an optional property role can be added to give the name of the character that is played.

Examples:

  • {"type": "director", "name": "David Benioff"}
  • {"type": "writer", "name": "George R.R. Martin"}
  • {"type": "actor", "name": "Kit Harington", "role": "John Snow"}

Notes

  • The types are based on the values that xmltv supports and seem like a good list of possible items. It also closely matched the different types I saw in the API of TV Vlaanderen.
  • IPTV Simple only supports director, writer and actor, so we have to make a mapping when writing the EPG.
  • Also, when a parsing error occurs, we log it and continue with the next program instead of just stopping the processing.

@michaelarnauts michaelarnauts added the enhancement New feature or request label Nov 11, 2020
@michaelarnauts michaelarnauts changed the title Allow passing credits with the EPG data. Allow passing credits with the EPG data Nov 11, 2020
@michaelarnauts michaelarnauts merged commit a039bf5 into master Nov 11, 2020
@michaelarnauts michaelarnauts deleted the credits branch November 11, 2020 12:09
@dagwieers dagwieers added this to the v0.2.2 milestone Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants