forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
stream: do not unconditionally call
_read()
on resume()
`readable.resume()` calls `.read(0)`, which in turn previously set `needReadable = true`, and so a subsequent `.read()` call would call `_read()` even though enough data was already available. This can lead to elevated memory usage, because calling `_read()` when enough data is in the readable buffer means that backpressure is not being honoured. Fixes: nodejs#26957
- Loading branch information
Showing
2 changed files
with
22 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const { Readable } = require('stream'); | ||
|
||
// readable.resume() should not lead to a ._read() call being scheduled | ||
// when we exceed the high water mark already. | ||
|
||
const readable = new Readable({ | ||
read: common.mustNotCall(), | ||
highWaterMark: 100 | ||
}); | ||
|
||
// Fill up the internal buffer so that we definitely exceed the HWM: | ||
for (let i = 0; i < 10; i++) | ||
readable.push('a'.repeat(200)); | ||
|
||
// Call resume, and pause after one chunk. | ||
// The .pause() is just so that we don’t empty the buffer fully, which would | ||
// be a valid reason to call ._read(). | ||
readable.resume(); | ||
readable.once('data', common.mustCall(() => readable.pause())); |