Skip to content

Commit

Permalink
deps: V8: cherry-pick 5678ebe8f6c4
Browse files Browse the repository at this point in the history
Original commit message:

    [M86 LTS] Disable failing tests

    Disable failing tests backported from ToT. No existing tests
    are disabled.

    No-Try: true
    No-Presubmit: true
    No-Tree-Checks: true
    Bug: None
    Change-Id: I94d2cd4827ce6fd1875c66912b4841a4a7c72ab3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764754
    Reviewed-by: Artem Sumaneev <asumaneev@google.com>
    Commit-Queue: Victor-Gabriel Savu <vsavu@google.com>
    Cr-Commit-Position: refs/branch-heads/8.6@{nodejs#70}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@5678ebe

PR-URL: nodejs#38275
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
  • Loading branch information
targos committed Apr 30, 2021
1 parent 0bd8e14 commit 77b7a3b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.47',
'v8_embedder_string': '-node.48',

##### V8 defaults for Node.js #####

Expand Down
9 changes: 9 additions & 0 deletions deps/v8/test/mjsunit/mjsunit.status
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@
# All tests in the bug directory are expected to fail.
'bugs/*': [FAIL],

##############################################################################
# LTS failing tests.
# Introduced in https://chromium-review.googlesource.com/c/v8/v8/+/2584242
'regress/wasm/regress-1146861': [SKIP],
# Introduced in https://chromium-review.googlesource.com/c/v8/v8/+/2656263
'regress/wasm/regress-1153442': [SKIP],
# Introduced in https://chromium-review.googlesource.com/c/v8/v8/+/2649176
'regress/wasm/regress-1161654': [SKIP],

##############################################################################
# Open bugs.

Expand Down

0 comments on commit 77b7a3b

Please sign in to comment.