Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since v1.2.2, Closing a model after its connection is closed throws #25

Closed
odalet opened this issue Nov 23, 2020 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@odalet
Copy link

odalet commented Nov 23, 2020

This behavior is inconsistent with what the actual RabbitMQ client does.

Given this code:

var factory = new FakeConnectionFactory();
var connection = factory.CreateConnection();

var model = connection.CreateModel();
connection.Close();
model.Close();

the line model.Close() throws an AlreadyClosedException whereas, when the fake factory is replaced by RabbitMQ.Client.ConnectionFactory, no exception is thrown.

We should be consistent with RabbitMQ.Client's behavior.

odalet pushed a commit that referenced this issue Nov 23, 2020
@odalet
Copy link
Author

odalet commented Nov 23, 2020

Fixed in release v1.3.1

@odalet odalet closed this as completed Nov 23, 2020
@odalet odalet added the bug Something isn't working label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant