Upgrade to Yarn Berry (3.2) #2154

mrtnzlml · 2021-04-06T21:12:17Z

See: https://yarnpkg.com/getting-started/migration

TODO:

get rid of "module": false from package.json (we usually disable it anyway)
fix getWorkspaceDependencies function (it currently supports only Yarn v1 format) Monorepo utils: add support for Yarn Berry #4045
~~change version in Bazel (Yarn PnP Support bazel-contrib/rules_nodejs#1599) ⚠️~~ Bazel removed (Universe: remove Bazel files #2794)
what to do with Dependabot? (Support Yarn v2 dependabot/dependabot-core#1297) ⚠️ alternative: https://docs.renovatebot.com/configure-renovate/
update some Monorepo Scanner rules to match the new system
check that commands like yw @adeira/abacus-backoffice dev or yw @adeira/sx-design storybook still work as expected
fix yarn monorepo-babel-node src/sx/src/css-properties/generateFlowTypes.js
regenerate yarn.lock file (before merging)

Current status of yarn test:

yarn flow ✅
yarn lint --all ✅
yarn test-only --all ✅
yarn scanner ✅
./node_modules/.bin/relay-compiler ✅

Learnings:

~~The dependencies must be specified directly and we cannot access dependencies of dependencies. We are doing this ugly thing in yarn run lint for example.~~

Closes: #1734

The reasoning is fairly simple: nobody is actively working on integrating with Bazel and there are no plans/capacity to do so. It might be because Bazel is quite complex, and it's hard to set up it in a way we need it to be. Moreover, it's blocking other efforts like this one for example: #2154 (Yarn 2). Note: this doesn't mean that there is no need for something like Bazel. However, it doesn't have to be Bazel (preferably something simpler that does the job well enough).

The reasoning is fairly simple: nobody is actively working on integrating with Bazel and there are no plans/capacity to do so. It might be because Bazel is quite complex, and it's hard to set up it in a way we need it to be. Moreover, it's blocking other efforts like this one for example: adeira/universe#2154 (Yarn 2). Note: this doesn't mean that there is no need for something like Bazel. However, it doesn't have to be Bazel (preferably something simpler that does the job well enough). adeira-source-id: 4806cd43ff2ef8ca082d7b51e6c9da493e55f946

Yarn Berry does this automatically, offloading #2154

Offloading: #2154

Offloading: adeira/universe#2154 adeira-source-id: 578d5959a067fdce88339aee6028d3077802a080

History repeats: I am configuring Renovate bot again. Dependabot is great and it's awesome that it's integrated into GitHub natively. Unfortunately, it does not support Yarn Berry and seems like it won't anytime soon (dependabot/dependabot-core#1297). I would like to configure Renovate bot instead which should support Yarn Berry without many problems and therefore unblock our Yarn upgrade (#2154). At this moment I would like to keep both Dependabot and Renovate bot enabled to see if everything works correctly, and eventually I'd like to turn off Dependabot completely or limit it to things Renovate bot doesn't support. Closes: #3799

See: https://yarnpkg.com/getting-started/migration Closes: #1734

mrtnzlml · 2022-03-07T16:27:19Z

I am currently not aware of any other issues that would need to be fixed so let's gooo! 🚀

The reasoning is fairly simple: nobody is actively working on integrating with Bazel and there are no plans/capacity to do so. It might be because Bazel is quite complex, and it's hard to set up it in a way we need it to be. Moreover, it's blocking other efforts like this one for example: adeira/universe#2154 (Yarn 2). Note: this doesn't mean that there is no need for something like Bazel. However, it doesn't have to be Bazel (preferably something simpler that does the job well enough). adeira-source-id: 4806cd43ff2ef8ca082d7b51e6c9da493e55f946