Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump app.cash.paparazzi from 1.3.1 to 1.3.3 #1010

Merged
merged 5 commits into from
May 27, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 1, 2024

Bumps app.cash.paparazzi from 1.3.1 to 1.3.3.

Release notes

Sourced from app.cash.paparazzi's releases.

1.3.3

New

  • Migrate Paparazzi to layoutlib Hedgehog 2023.1.1
  • Compose 1.5.8
  • Kotlin 1.9.22
  • [Gradle Plugin] Gradle 8.6
  • [Gradle Plugin] Android Gradle Plugin 8.2.1

Fixed

  • Update the DeviceConfig screenWidth internally for accessibility tests
  • Fix variant caching issues in new resource/asset loading mechanisms
  • Remove legacy resources/assets loading mechanism
  • Set HardwareConfig width and height based on orientation
  • Apply round screen qualifier to device config
  • Restrict Paparazzi's public API
  • Remove obsolete NEXUS_5_LAND DeviceConfig
  • Fix formatting so that all digits show upon failure
  • Stop resolving dependencies at configuration time
  • Use our own internal HandlerDispatcher for Compose Ui tests
  • Include generated string resources
  • Reset logger to prevent swallowing exceptions

Kudos to @​gamepro65, @​kevinzheng-ap, @​BrianGardnerAtl, @​adamalyyan, and others for contributions this release!

1.3.2

NOTE: Due to a known issue with how Guava now publishes its artifact, you will need to apply the following snippet workaround to your root build.gradle (Groovy-based, Kotlin impls will vary slightly):

subprojects {
  plugins.withId("app.cash.paparazzi") {
    // Defer until afterEvaluate so that testImplementation is created by Android plugin.
    afterEvaluate {
      dependencies.constraints {
        add("testImplementation", "com.google.guava:guava") {
          attributes {
            attribute(
              TargetJvmEnvironment.TARGET_JVM_ENVIRONMENT_ATTRIBUTE,
              objects.named(TargetJvmEnvironment, TargetJvmEnvironment.STANDARD_JVM)
            )
          }
          because("LayoutLib and sdk-common depend on Guava's -jre published variant." +
            "See https://github.com/cashapp/paparazzi/issues/906.")
        }
      }
    }
  }
}

See also: google/guava#6801.

New

... (truncated)

Changelog

Sourced from app.cash.paparazzi's changelog.

[1.3.3] - 2024-03-01

New

  • Migrate Paparazzi to layoutlib Hedgehog 2023.1.1
  • Compose 1.5.8
  • Kotlin 1.9.22
  • [Gradle Plugin] Gradle 8.6
  • [Gradle Plugin] Android Gradle Plugin 8.2.1

Fixed

  • Update the DeviceConfig screenWidth internally for accessibility tests
  • Fix variant caching issues in new resource/asset loading mechanisms
  • Remove legacy resources/assets loading mechanism
  • Set HardwareConfig width and height based on orientation
  • Apply round screen qualifier to device config
  • Restrict Paparazzi's public API
  • Remove obsolete NEXUS_5_LAND DeviceConfig
  • Fix formatting so that all digits show upon failure
  • Stop resolving dependencies at configuration time
  • Use our own internal HandlerDispatcher for Compose Ui tests
  • Include generated string resources
  • Reset logger to prevent swallowing exceptions

Kudos to @​gamepro65, @​kevinzheng-ap, @​BrianGardnerAtl, @​adamalyyan, and others for contributions this release!

[1.3.2] - 2024-01-13

NOTE: Due to a known issue with how Guava now publishes its artifact, you will need to apply the following snippet workaround to your root build.gradle:

subprojects {
  plugins.withId("app.cash.paparazzi") {
    // Defer until afterEvaluate so that testImplementation is created by Android plugin.
    afterEvaluate {
      dependencies.constraints {
        add("testImplementation", "com.google.guava:guava") {
          attributes {
            attribute(
              TargetJvmEnvironment.TARGET_JVM_ENVIRONMENT_ATTRIBUTE,
              objects.named(TargetJvmEnvironment, TargetJvmEnvironment.STANDARD_JVM)
            )
          }
          because("LayoutLib and sdk-common depend on Guava's -jre published variant." +
            "See https://github.com/cashapp/paparazzi/issues/906.")
        }
      }
    }
  }
}

See also: google/guava#6801.

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot force-pushed the dependabot/gradle/app.cash.paparazzi-1.3.3 branch from 26a19bb to 856b5fa Compare March 4, 2024 19:36
@dependabot dependabot bot force-pushed the dependabot/gradle/app.cash.paparazzi-1.3.3 branch 3 times, most recently from 57f8fa8 to e362d9a Compare March 7, 2024 11:44
@dependabot dependabot bot force-pushed the dependabot/gradle/app.cash.paparazzi-1.3.3 branch 5 times, most recently from 0c31992 to cdae1f2 Compare March 19, 2024 16:20
@SimonMarquis SimonMarquis force-pushed the dependabot/gradle/app.cash.paparazzi-1.3.3 branch from cdae1f2 to d68f2ee Compare April 5, 2024 12:17
@dependabot dependabot bot requested a review from a team as a code owner April 5, 2024 12:17
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: validation
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dependencyGuard 8.7 Build Scan NOT_PUBLISHED
spark-android spotlessCheck :build-logic:spotlessCheck 8.7 Build Scan NOT_PUBLISHED

@SimonMarquis SimonMarquis force-pushed the dependabot/gradle/app.cash.paparazzi-1.3.3 branch from d68f2ee to 3865004 Compare April 5, 2024 12:36
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.7 Build Scan NOT_PUBLISHED
spark-android globalCiUnitTest verifyPaparazziRelease 8.7 Build Scan NOT_PUBLISHED

Copy link
Contributor

github-actions bot commented Apr 5, 2024

🚨 UI regression detected! Checkout the paparazzi-delta artifact.
If these changes are expected, you can either:

  • manually run the gradlew recordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.7 Build Scan NOT_PUBLISHED
spark-android globalCiUnitTest verifyPaparazziRelease 8.7 Build Scan NOT_PUBLISHED

@SimonMarquis
Copy link
Member

@spark-ui-bot paparazzi golden images

Copy link
Member

@SimonMarquis SimonMarquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some screenshots diff are unexpected. Is this an error on our project, or a Paparazzi defect?

@SimonMarquis
Copy link
Member

@soulcramer it is because Paparazzi now supports pseudolocalisation, and we used to specify this in the paparazzi rule:

What should we do?

@soulcramer
Copy link
Contributor

Let's remove the pseudolocalisation from the rule 🤔

@soulcramer
Copy link
Contributor

However for the others diffs they seems normal to me since they're bug fixes from paparazzi (the device orientation being taken into account finally) and the upgrade to layout lib (the textlink annotated tring is finally rendered as on device)

@SimonMarquis SimonMarquis force-pushed the dependabot/gradle/app.cash.paparazzi-1.3.3 branch 2 times, most recently from 3096e1b to e4540ee Compare April 5, 2024 16:19
@SimonMarquis
Copy link
Member

@spark-ui-bot paparazzi

SimonMarquis
SimonMarquis previously approved these changes Apr 5, 2024
kazaky
kazaky previously approved these changes May 6, 2024
@kazaky
Copy link
Contributor

kazaky commented May 6, 2024

@spark-ui-bot paparazzi

dependabot bot and others added 4 commits May 6, 2024 15:03
Bumps [app.cash.paparazzi](https://github.com/cashapp/paparazzi) from 1.3.1 to 1.3.3.
- [Release notes](https://github.com/cashapp/paparazzi/releases)
- [Changelog](https://github.com/cashapp/paparazzi/blob/master/CHANGELOG.md)
- [Commits](cashapp/paparazzi@1.3.1...1.3.3)

---
updated-dependencies:
- dependency-name: app.cash.paparazzi
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@SimonMarquis SimonMarquis dismissed stale reviews from kazaky and themself via c9cc64d May 6, 2024 13:04
@SimonMarquis SimonMarquis force-pushed the dependabot/gradle/app.cash.paparazzi-1.3.3 branch from 97ec6f8 to c9cc64d Compare May 6, 2024 13:04
Copy link
Contributor

github-actions bot commented May 6, 2024

🚨 UI regression detected! Checkout the paparazzi-delta artifact.
If these changes are expected, you can either:

  • manually run the gradlew recordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

Copy link
Contributor

github-actions bot commented May 6, 2024

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.7 Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.7 Build Scan not published

@SimonMarquis
Copy link
Member

@spark-ui-bot paparazzi

Copy link
Contributor Author

dependabot bot commented on behalf of github May 24, 2024

A newer version of app.cash.paparazzi exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@soulcramer soulcramer disabled auto-merge May 27, 2024 08:47
@soulcramer soulcramer merged commit fedfd7b into main May 27, 2024
7 checks passed
@soulcramer soulcramer deleted the dependabot/gradle/app.cash.paparazzi-1.3.3 branch May 27, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants