-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump app.cash.paparazzi from 1.3.1 to 1.3.3 #1010
Conversation
26a19bb
to
856b5fa
Compare
57f8fa8
to
e362d9a
Compare
0c31992
to
cdae1f2
Compare
cdae1f2
to
d68f2ee
Compare
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: validation
|
d68f2ee
to
3865004
Compare
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: build-test-lint
|
🚨 UI regression detected! Checkout the paparazzi-delta artifact.
|
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: build-test-lint
|
@spark-ui-bot paparazzi golden images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some screenshots diff are unexpected. Is this an error on our project, or a Paparazzi defect?
@soulcramer it is because Paparazzi now supports pseudolocalisation, and we used to specify this in the paparazzi rule: spark-android/spark-screenshot-testing/src/test/kotlin/com/adevinta/spark/PaparazziRule.kt Line 73 in 7d26250
What should we do? |
Let's remove the pseudolocalisation from the rule 🤔 |
However for the others diffs they seems normal to me since they're bug fixes from paparazzi (the device orientation being taken into account finally) and the upgrade to layout lib (the textlink annotated tring is finally rendered as on device) |
3096e1b
to
e4540ee
Compare
@spark-ui-bot paparazzi |
@spark-ui-bot paparazzi |
Bumps [app.cash.paparazzi](https://github.com/cashapp/paparazzi) from 1.3.1 to 1.3.3. - [Release notes](https://github.com/cashapp/paparazzi/releases) - [Changelog](https://github.com/cashapp/paparazzi/blob/master/CHANGELOG.md) - [Commits](cashapp/paparazzi@1.3.1...1.3.3) --- updated-dependencies: - dependency-name: app.cash.paparazzi dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
97ec6f8
to
c9cc64d
Compare
🚨 UI regression detected! Checkout the paparazzi-delta artifact.
|
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: build-test-lint
|
@spark-ui-bot paparazzi |
A newer version of app.cash.paparazzi exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps app.cash.paparazzi from 1.3.1 to 1.3.3.
Release notes
Sourced from app.cash.paparazzi's releases.
... (truncated)
Changelog
Sourced from app.cash.paparazzi's changelog.
... (truncated)
Commits
9a52dfd
Prepare version 1.3.3bcc24c7
Revert "Initial API spike based on Paparazzi2.kt notes (#1286)" (#1301)a721862
Update dependency python-dateutil to v2.9.0 (#1313)5764f91
Update dependency com.google.truth:truth to v1.4.2 (#1312)ca87085
Update Kotlin and Compose (#1287)0b8a85f
Reset logger to prevent swallowing exceptions (#1309)0c15663
Update dependency mkdocs-material to v9.5.12 (#1308)5439780
Fixes Issue About Generated Strings Rendering (#1307)7276226
Use our own HandlerDispatcher for ComposeUi tests (#1306)5d158e6
Update dependency mkdocs-material to v9.5.11 (#1303)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)