chore!: Remove the legacy API #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: validation
|
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2023 Adevinta | |||
| * Copyright (c) 2023-2024 Adevinta | |||
There was a problem hiding this comment.
@soulcramer can you check your IDE if you don't have any custom copyright code, because this is not the expected format 🙈
There was a problem hiding this comment.
Damn why is this coming back 💀
I'll check
kazaky
approved these changes
May 23, 2024
kazaky
previously approved these changes
May 28, 2024
soulcramer
force-pushed
the
no-legacy
branch
from
1803ada to
9f189c6
Compare
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: build-test-lint
|
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: validation
|
soulcramer
force-pushed
the
no-legacy
branch
from
cb07dc1 to
771fcde
Compare
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: validation
|
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: validation
|
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: validation
|
soulcramer
force-pushed
the
no-legacy
branch
from
b0051af to
6e303b1
Compare
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: validation
|
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: build-test-lint
|
|
🚨 UI regression detected! Checkout the paparazzi-delta artifact.
|
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: build-test-lint
|
This enum was useful to test component in the different color modes
Co-authored-by: spark-ui-bot <spark-ui-bot@users.noreply.github.com>
soulcramer
force-pushed
the
no-legacy
branch
from
a2bc03e to
1553c79
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
We remove all apis and mentions of the legacy Brikke theme / DS
🤔 Context
Closes #971
✅ Checklist
spark-designGitHub team.