Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component] Dropdown - callback called twice in onChange event #1918

Closed
acd02 opened this issue Feb 28, 2024 · 0 comments · Fixed by #1919
Closed

[Component] Dropdown - callback called twice in onChange event #1918

acd02 opened this issue Feb 28, 2024 · 0 comments · Fixed by #1919
Assignees
@acd02
Labels
Component Related to a component Type: Bug A bug to fix
Milestone
2024 Q1 - Sprint 4

Comments

@acd02
Copy link
Contributor

acd02 commented Feb 28, 2024 •
edited
Loading

We have identified an issue where callbacks are being triggered twice during the onChange event when multiple prop is truthy.
After investigating, we found that the bug originates from Downshift, the library we use to manage our logic.
See the corresponding issue
@acd02 acd02 added the Type: Bug A bug to fix label Feb 28, 2024
@acd02 acd02 self-assigned this Feb 28, 2024
acd02 added a commit that referenced this issue Feb 28, 2024
@acd02
fix(dropdown): update to downshift 8.3.2
ea75c37 
Update Downshift to version 8.3.2 to resolve issue of callbacks triggering twice during the onChange
event when multiple prop is true

#1918
@acd02 acd02 mentioned this issue Feb 28, 2024
Merged
@acd02 acd02 linked a pull request Feb 28, 2024 that will close this issue
fix(dropdown): update to downshift 8.3.2 #1919
Merged
acd02 added a commit that referenced this issue Feb 28, 2024
@acd02
fix(dropdown): update to downshift 8.3.2
4952bed 
Update Downshift to version 8.3.2 to resolve issue of callbacks triggering twice during the onChange
event when multiple prop is true

#1918
@acd02 acd02 added the Component Related to a component label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acd02 acd02

Labels
Component Related to a component Type: Bug A bug to fix
Projects
None yet
Milestone
2024 Q1 - Sprint 4
Development

Successfully merging a pull request may close this issue.

fix(dropdown): update to downshift 8.3.2 adevinta/spark
1 participant
@acd02