Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 1270] Feature: disable operator templates generation #1272

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

gwydionmv
Copy link
Contributor

@gwydionmv gwydionmv commented Jun 12, 2024

Description

Included property for disabling operator templates generation, same procedure as the one already available for enabling/disabling keycloak templates.

Issues

#1270

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 12, 2024
@gwydionmv gwydionmv marked this pull request as ready for review June 12, 2024 11:47
@gwydionmv gwydionmv requested a review from a team as a code owner June 12, 2024 11:47
@gwydionmv gwydionmv requested review from eyenx and gianklug June 12, 2024 11:47
@4censord 4censord linked an issue Jun 12, 2024 that may be closed by this pull request
@tongpu tongpu requested review from hairmare and maxthier June 12, 2024 12:28
@hairmare
Copy link
Contributor

Hey @gwydionmv thanks for the PR!

The "Lint and Install" jobs is currently complaining because it's missing version bumps in the tests/ subdir and the chart's README.md will also need to be updated with the new version + value.

The failing "pre-commit" CI job might just be pure flakiness. I'm not quite sure since we have seen it fail in a while.

The following commands should update the things I mentioned:

# update unittest snapshots
helm unittest --update-snapshot charts/keycloak-operator

# update README
pre-commit run -a

May i ask you to run them and push the proposed changes as well? If you run into any issues, please let us now and we can run them on your behalf.

Thanks again!

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 13, 2024
@gwydionmv
Copy link
Contributor Author

hello @hairmare ! Thanks for your comments. I run both commands with successful output, README and snapshots are now updated :D could you please doublecheck if everything is ok? 😄

Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hairmare hairmare merged commit 9bc692d into adfinis:main Jun 13, 2024
3 checks passed
@hairmare
Copy link
Contributor

tysm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[keycloak-operator] Disable operator templates
2 participants