-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue 1270] Feature: disable operator templates generation #1272
Conversation
Hey @gwydionmv thanks for the PR! The "Lint and Install" jobs is currently complaining because it's missing version bumps in the The failing "pre-commit" CI job might just be pure flakiness. I'm not quite sure since we have seen it fail in a while. The following commands should update the things I mentioned: # update unittest snapshots
helm unittest --update-snapshot charts/keycloak-operator
# update README
pre-commit run -a May i ask you to run them and push the proposed changes as well? If you run into any issues, please let us now and we can run them on your behalf. Thanks again! |
hello @hairmare ! Thanks for your comments. I run both commands with successful output, README and snapshots are now updated :D could you please doublecheck if everything is ok? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tysm! |
Description
Included property for disabling operator templates generation, same procedure as the one already available for enabling/disabling keycloak templates.
Issues
#1270
Checklist
artifacthub.io/changes
annotation inChart.yaml
, check the example in the documentation.pre-commit run
docs/